Use Postgres database for unit testing (#2920)

* Use postgres for testing on Travis

* fixed tests

1. Removed get_api_400 test as it is no longer valid now that postgres db is used.
2. Fixed tests that were wrong the very start. Thanks to SQLite, they were able to get away.

* updated README with new test instructions

* fixed robot tests by re-initializing db after unittests

.travis.yml

@@ -23,6 +23,12 @@ before_script:
 # command to run tests
 script:
   - nosetests tests/unittests -v --with-coverage
+  # re-init db
+  - psql -c 'drop database if exists test;' -U postgres
+  - psql -c 'create database test;' -U postgres
+  - python manage.py initialize_db -c open_event_test_user@fossasia.org:fossasia
+  - python manage.py runserver &
+  # robot
   - robot tests/robot
 # upload coverage
 after_success:

README.md

@@ -62,13 +62,13 @@ OAuth is used to get information from Facebook and Google accounts, that enables
 
 #### Twitter
 
-Twitter feed integration is provided in the public event pages. 
+Twitter feed integration is provided in the public event pages.
 
 Required keys can be obtained from [https://dev.twitter.com/overview/documentation](https://dev.twitter.com/overview/documentation)
 
 #### Instagram
 
-It is possible to extend the functionality and offer images from Instagram in the event service. 
+It is possible to extend the functionality and offer images from Instagram in the event service.
 
 Required keys can be obtained from [https://www.instagram.com/developer/authentication/](https://www.instagram.com/developer/authentication/).
 
@@ -81,7 +81,7 @@ Required keys can be obtained from [https://maps.googleapis.com/maps/api](https:
 #### Media Storage - Local/Amazon S3/Google Cloud
 
 Media (like audio, avatars and logos) can be stored either Locally or on Amazon S3 or on Google Storage.
- 
+
 1. [Amazon S3 Setup Instructions](/docs/AMAZON_S3.md)
 1. [Google Cloud Setup Instructions](https://cloud.google.com/storage/docs/migrating#defaultproj)
 
@@ -137,10 +137,10 @@ The event data and the sessions can be exported in various formats.
 
 ## Roles
 
-The system has two kind of role type. 
+The system has two kind of role type.
 
-1. System roles are related to the Open Event organization and operator of the application. 
-2. Event Roles are related to the users of the system with their different permissions. 
+1. System roles are related to the Open Event organization and operator of the application.
+2. Event Roles are related to the users of the system with their different permissions.
 
 Read more [here](/docs/ROLES.md).
 
@@ -181,13 +181,21 @@ pip install -r requirements/tests.txt
 
 #### Running unit tests
 
-* Go to the project directory and run the following command:
+* Open Event uses Postgres database for testing. So set `DATABASE_URL` as a postgres database. Here is an example.
+
+```sh
+export DATABASE_URL=postgresql://test_user:test@127.0.0.1:5432/opev_test
+# format is postgresql://USERNAME:PASSWORD@ADDRESS/DATABASE_NAME
+export APP_CONFIG=config.TestingConfig
+```
+
+* Then go to the project directory and run the following command:
 ```
 python -m unittest discover tests/unittests/
 ```
 * It will run each test one by one.
 
-* You can also use the following command to run tests using nosetests :
+* You can also use the following command to run tests using nosetests:
 ```
 nosetests tests/unittests/
 ```
@@ -219,7 +227,7 @@ Open Event is being translated using Weblate, a web tool designed to ease transl
 
 If you would like to contribute to translation of Open Event, you need to [register on this server](https://hosted.weblate.org/accounts/register/).
 
-Once you have activated your account just proceed to the [translation section](https://hosted.weblate.org/projects/open-event/).   
+Once you have activated your account just proceed to the [translation section](https://hosted.weblate.org/projects/open-event/).
 
 
 ## Contributions, Bug Reports, Feature Requests

tests/unittests/functionality/test_microlocation.py

@@ -13,8 +13,12 @@ def setUp(self):
         self.app = Setup.create_app()
 
     def test_add_microlocation_to_db(self):
-        microlocation = ObjectMother.get_microlocation()
         with app.test_request_context():
+            # create event
+            event = ObjectMother.get_event()
+            save_to_db(event, 'Event saved')
+            # test
+            microlocation = ObjectMother.get_microlocation()
             save_to_db(microlocation, "Microlocation saved")
             self.assertEqual(microlocation.id, 1)
             self.assertEqual(microlocation.event_id, 1)

tests/unittests/functionality/test_session.py

@@ -9,11 +9,16 @@
 class TestSessionApi(OpenEventViewTestCase):
 
     def test_add_session_to_db(self):
-        session = ObjectMother.get_session()
         with app.test_request_context():
+            # create event
+            event = ObjectMother.get_event()
+            save_to_db(event, 'Event saved')
+            # test
+            session = ObjectMother.get_session()
             save_to_db(session, "Session saved")
             self.assertEqual(session.id, 1)
             self.assertEqual(session.event_id, 1)
 
+
 if __name__ == '__main__':
     unittest.main()

tests/unittests/setup_database.py

@@ -23,7 +23,7 @@ def create_app():
         app.config['BROKER_BACKEND'] = 'memory'
         # app.config['CELERY_BROKER_URL'] = ''
         # app.config['CELERY_RESULT_BACKEND'] = ''
-        app.config['SQLALCHEMY_DATABASE_URI'] = 'sqlite:///' + os.path.join(_basedir, 'test.db')
+        app.config['SQLALCHEMY_DATABASE_URI'] = os.environ.get('DATABASE_URL', 'sqlite:///' + os.path.join(_basedir, 'test.db'))
         app.secret_key = 'super secret key'
         app.logger.addHandler(logging.StreamHandler(sys.stdout))
         app.logger.setLevel(logging.ERROR)
@@ -39,4 +39,10 @@ def create_app():
     def drop_db():
         with app.test_request_context():
             db.session.remove()
-            db.drop_all()
+            if app.config['SQLALCHEMY_DATABASE_URI'].find('postgresql://') > -1:
+                # drop_all has problems with foreign keys in postgres database (cyclic dependency)
+                db.engine.execute("drop schema if exists public cascade")
+                db.engine.execute("create schema public")
+            else:
+                # drop all works for SQLite and should work for other DBMS like MySQL, Mongo etc
+                db.drop_all()

tests/unittests/test_db_performance.py

@@ -49,6 +49,11 @@ def test_db_events(self):
 
     def test_db_sessions(self):
         with app.test_request_context():
+            # create event
+            event = ObjectMother.get_event()
+            db.session.add(event)
+            db.session.commit()
+            # test
             for i in range(1, 10000):
                 session = ObjectMother.get_session()
                 session.name = 'Session' + str(i)
@@ -83,10 +88,6 @@ def test_db_users(self):
                             query.statement, query.parameters, query.duration, query.context))
                         text_file.write("\n")
 
-    def tearDown(self):
-        with app.test_request_context():
-            db.drop_all()
-
 
 if __name__ == '__main__':
     unittest.main()

tests/unittests/views/admin/test_session.py

@@ -91,6 +91,8 @@ def test_session_reject(self):
 
     def test_session_delete(self):
         with app.test_request_context():
+            event = ObjectMother.get_event()
+            save_to_db(event, "Event Saved")
             session = ObjectMother.get_session()
             save_to_db(session, "Session Saved")
             url = url_for('event_sessions.delete_session', event_id=1, session_id=session.id)