Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket start time according to event timezone #2818

Closed
wants to merge 2 commits into from

Conversation

shubham-padia
Copy link
Member

Fixes #2805 .
Visit http://orga3.herokuapp.com/ for a demo.
Please review.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 74.255% when pulling 5e0adaf on shubham-padia:development into 348c047 on fossasia:development.

@codecov-io
Copy link

codecov-io commented Jan 1, 2017

Current coverage is 74.48% (diff: 100%)

Merging #2818 into development will decrease coverage by 0.10%

@@           development      #2818   diff @@
=============================================
  Files              218        218          
  Lines            14353      14353          
  Methods              0          0          
  Messages             0          0          
  Branches             0          0          
=============================================
- Hits             10706      10691    -15   
- Misses            3647       3662    +15   
  Partials             0          0          

Powered by Codecov. Last update 348c047...5e0adaf

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 74.255% when pulling 5e0adaf on shubham-padia:development into 348c047 on fossasia:development.

@mariobehling
Copy link
Member

The commit also seems to change the event start time, which results in "invalid time range".

screenshot from 2017-01-01 23-52-08

@mariobehling
Copy link
Member

Oh, it seems this bug also exists now on eventyay.com.

@mariobehling
Copy link
Member

Does not solve the issue.

Also I see that the pre-filled ticket sales time starts at 11pm and ends at 10pm.

The preview states ticket sales "will" start, but the time has passed already.

screenshot from 2017-01-01 23-57-32

@shubham-padia
Copy link
Member Author

shubham-padia commented Jan 1, 2017

The issue that you mentioned in the comment is a different issue #2806 which is yet to be solved.
This pr solves #2805 according to which default start time for the ticket sales should be according to the event timezone

@shubham-padia
Copy link
Member Author

You can change the event timezone -> add a new ticket -> view start time of the ticket sales which will be according to the event timezone

@mariobehling
Copy link
Member

Event timezone is Berlin UTC +1. Sales shows "This ticket's sale will start on January 01, 2017 11:50 PM". Time is: January 2, 00:08. Ticket sales should be available, but they are not. Which time is the ticket sales using? The issue is that ticket sales are not available even though they should in the timezone defined.

@shubham-padia
Copy link
Member Author

The issue that you are mentioning is #2806 . This PR does not fix that.
This PR only fixes #2805 .

@shubham-padia
Copy link
Member Author

I think i'll close this for now and provide changes for both #2806 and #2805

@mariobehling
Copy link
Member

Ok, I think both need to be fixed together. Thank you for taking care!

@shubham-padia
Copy link
Member Author

No problem 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants