Fixes #3113: Adds from name to email

[abhinavk96]

Fixes #3113

Specifies from "Name" for emails in admin dashboard

[niranjan94]

@CosmicCoder96

Don't implement the name only for SMTP.

keep the name common to SMTP and Sendgrid and also implement on sendgrid.

[niranjan94]

And @CosmicCoder96 ... please comment on the issue before you start working on it so that we can ensure multiple people are not working on the same issue

[abhinavk96]

@niranjan94
Thanks for the review. I will be sure to keep that in mind.
I have now placed the from name text field on the upper part of the form to make it common to both. And since the 'payload' in helpers.py is common to both smtp and sendgrid, I believe this should suffice. Please review again.

[niranjan94]

@CosmicCoder96 no. this would fail for sendgrid. Sendgrid expects only an email ID in the from field. For sendgrid you'd need to put the name in the fromname field.

Please see https://sendgrid.com/docs/API_Reference/Web_API/mail.html

[niranjan94]

When using a third-party API/sdk, never assume a behavior. Always check the appropriate documentation and confirm.

[abhinavk96]

@niranjan94
Thanks for the advice. I have made the necessary changes.
This time I have tested by sending a mail using sendgrid API too.