Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Move images to proper directory and update references #1668

Merged
merged 5 commits into from Jun 12, 2019
Merged

chore: Move images to proper directory and update references #1668

merged 5 commits into from Jun 12, 2019

Conversation

ShridharGoel
Copy link
Member

@ShridharGoel ShridharGoel commented May 26, 2019 •
edited

Fixes #1667

Checklist:

  • I have checked for PMD and check-style issues
  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.

Changes:

Moved images to docs/images and updated references README.md accordingly.

@auto-label auto-label bot added the chore label May 26, 2019
mariobehling
mariobehling requested changes May 28, 2019
View reviewed changes
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move all images into the repo itself. There should not be any images in the Readme stored externally

@ShridharGoel
Copy link
Member Author

Updated.

@ShridharGoel ShridharGoel mentioned this pull request Jun 12, 2019
Closed
@fossasia fossasia deleted a comment from ci-reporter bot Jun 12, 2019
@fossasia fossasia deleted a comment from ci-reporter bot Jun 12, 2019
@fossasia fossasia deleted a comment from ci-reporter bot Jun 12, 2019
@fossasia fossasia deleted a comment from ci-reporter bot Jun 12, 2019
@mariobehling mariobehling merged commit 871ec31 into fossasia:development Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobehling mariobehling mariobehling approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move all images for documentation and Readme.md to /docs/images
2 participants
@ShridharGoel @mariobehling