Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrate CreateSessionPresenter to ViewModel #1738

Merged
merged 1 commit into from Jun 22, 2019
Merged

chore: Migrate CreateSessionPresenter to ViewModel #1738

merged 1 commit into from Jun 22, 2019

Conversation

ShridharGoel
Copy link
Member

Fixes #1500

Changes:

  • Converted CreateSessionPresenter to ViewModel.
  • Added unit tests for CreateSessionViewModel.

@auto-label auto-label bot added the chore label Jun 22, 2019
@fossasia fossasia deleted a comment Jun 22, 2019
@fossasia fossasia deleted a comment Jun 22, 2019
@iamareebjamal iamareebjamal merged commit 468df38 into fossasia:development Jun 22, 2019
@ShridharGoel ShridharGoel deleted the create-session-view-model branch June 23, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert CreateSessionPresenter to ViewModel
2 participants
@ShridharGoel @iamareebjamal