Remove function after update

fossasia · May 27, 2018 · 2525021 · 2525021
1 parent cc57ac2
commit 2525021
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/migrations/versions/194a5a2a44ef_.py b/migrations/versions/194a5a2a44ef_.py
@@ -42,11 +42,9 @@ def __init__(self, name, sqltext):
 
 
 def upgrade():
-    feedbacks_table = sa.sql.table('feedback',
-                                   sa.Column('rating', sa.VARCHAR())
-                                )
     op.create_or_replace_sp(update_rating_func)
-    op.execute("""UPDATE feedback SET rating=update_rating(rating)""")
+    op.execute("UPDATE feedback SET rating=update_rating(rating)")
+    op.execute("DROP FUNCTION update_rating(text)")
 
     op.alter_column('feedback', 'rating',
                existing_type=sa.VARCHAR(),