Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables with scroll bars in small resolutions #3138

Closed
mariobehling opened this issue Feb 2, 2017 · 18 comments
Closed

Tables with scroll bars in small resolutions #3138

mariobehling opened this issue Feb 2, 2017 · 18 comments

Comments

@mariobehling
Copy link
Member

mariobehling commented Feb 2, 2017

We are using some tables in a number of pages, e.g. /events/. In smaller resolutions these tables result in scrollbars within pages.

Please implement a solution without -internal- scroll bars.

This issue is also related to: #3059

screenshot from 2017-02-02 22-45-04

@SaptakS
Copy link
Contributor

SaptakS commented Feb 2, 2017

@mariobehling this was the solution we unanimously decided for tables in smaller resolution. Moreover I don't think this is a bug. This is a well discussed and decided plan that we implemented. There is no other way to make tables responsive. We discussed things like showing accordion and stuff but they all create lots of problem with dependencies. So I feel scroll in smaller resolution is the best solution as of now. @niranjan94 your views?

@SaptakS SaptakS changed the title Tabels with scroll bars in small resolutions Tables with scroll bars in small resolutions Feb 2, 2017
@SaptakS
Copy link
Contributor

SaptakS commented Feb 2, 2017

@niranjan94 @magdalenesuo check the comment here and tell your views... Do you think we should move to accordion for smaller screens?? Because I don't see any way of showing an entire table without scroll in smaller screens??? @mariobehling any suggestions???

@mariobehling
Copy link
Member Author

mariobehling commented Feb 2, 2017

@SaptakS To go for tables allowed us to get started and focus on the features itself. Genetella is an admin theme originally. So, it is not always the best solution. However, in this issue it would be out of scope to decide on the next steps of the design, but I hope we can get a more evolutionary solution here for the moment.

  1. It would be good to go through the tables and improve the distribution of columns. This would already help to avoid internal scroll bars.

  2. Rather than having scroll bars within the page, the scroll bars should appear for the whole page. Right now one issue is, as a user the last columns suddenly disappear and I do not even see that there is a scroll bar on the lower end of the page. So, please implement this not as a table with a scroll bar inside the page, but rather as a page that gets a scroll bar if the resolution is too small.

Does this make sense?

@SaptakS
Copy link
Contributor

SaptakS commented Feb 2, 2017

page that gets a scroll bar if the resolution is too small.

The problem with this is the top navbars looks weird then since the entire page will have a horizontal scroll but the width of the top navbar and other parts will remain same. So it might look weird. We need to find out something so that it doesn't break other designs as well.

@mariobehling
Copy link
Member Author

We need to find out something so that it doesn't break other designs as well.

Sure. Maybe there is no perfect solution for the moment, but as long as there are no internal scroll bars, it would be a step in a good direction.

@poush
Copy link
Member

poush commented Feb 10, 2017

I would like to give it a shot. I think I can provide a simple solution that will not break the design

@poush
Copy link
Member

poush commented Feb 10, 2017

screen shot 2017-02-10 at 10 42 21 pm

A scroll bar at this place can be placed easily on overflow.

@mariobehling
Copy link
Member Author

@poush Thank you, but the goal is to have no internal scroll bars. Cheers.

@poush
Copy link
Member

poush commented Feb 11, 2017

Well, in that case, we can provide a breakpoint where one column can be removed�. Let's say "status" column can be removed and status can be showed somewhere close to the order number and this way we can significantly remove the need of space of one column.

screen shot 2017-02-11 at 11 32 02 pm

@mariobehling
Copy link
Member Author

we can provide a breakpoint where one column can be removed

Very nice idea. This could work out, as we still have the filters. Excellent!

@mariobehling
Copy link
Member Author

Actually, in fact we could get rid of the column "Order Status" completely and integrate it in the "Order Column" that you show.

@poush
Copy link
Member

poush commented Feb 11, 2017

Great then, I will make a PR for this.

@SaptakS
Copy link
Contributor

SaptakS commented Feb 12, 2017

The PR fixes this problem for only orders table... But I believe this problem is there in all tables..

@SaptakS SaptakS reopened this Feb 12, 2017
@poush
Copy link
Member

poush commented Feb 12, 2017

I will make these changes on all other table too.

@mariobehling
Copy link
Member Author

Please reduce the width of "#" and "Qty" in all ticket order/attendee tables as well. Thank you.

@poush
Copy link
Member

poush commented Feb 19, 2017

Attendee and Orders page have been fixed.

@mariobehling @SaptakS @niranjan94 Can you suggest something for Manage Events page? Can we hide one or two column on reducing screen size?

First look tells me that width can be reduced through "Public Url" column.

@mariobehling
Copy link
Member Author

Last column can probably also be reduced.

@niranjan94
Copy link
Member

To be handled in frontend. Issue will be re-created on the frontend repo. No progress here anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants