Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5409 error in access_code.py #5410

Merged
merged 2 commits into from Oct 11, 2018

Conversation

prabhupant
Copy link
Contributor

Fixes #5409

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

in the repr() function of this file, in place of self.id, it should be self.code

Changes proposed in this pull request:

  • correction in the repr function of the mentioned file

@prabhupant prabhupant changed the title In repr function, change self.id to self.code Fixes #5409 error in access_code.py Oct 8, 2018
@codecov
Copy link

codecov bot commented Oct 8, 2018

Codecov Report

Merging #5410 into development will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5410   +/-   ##
============================================
  Coverage        62.69%   62.69%           
============================================
  Files              261      261           
  Lines            12635    12635           
============================================
  Hits              7921     7921           
  Misses            4714     4714
Impacted Files Coverage Δ
app/models/access_code.py 60.46% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80dc203...68cb94f. Read the comment docs.

@bhaveshAn bhaveshAn merged commit cb11f14 into fossasia:development Oct 11, 2018
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Jan 30, 2019
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in models/access_code.py
4 participants