Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timezone to generated ticket pdf. #5576

Merged
merged 1 commit into from Feb 2, 2019

Conversation

Anupam-dagar
Copy link
Member

@Anupam-dagar Anupam-dagar commented Feb 1, 2019

This PR is in continuation to #5573

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

Added timezone to the time in the generated ticket pdf.

e263b2e7-96f6-4787-ae59-cd92ce302e20-pdf 01-02-2019 23-21-18

@Anupam-dagar
Copy link
Member Author

@CosmicCoder96 @iamareebjamal This adds the timezone to the ticket.
Please review.

@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #5576 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5576   +/-   ##
============================================
  Coverage        63.23%   63.23%           
============================================
  Files              265      265           
  Lines            12742    12742           
============================================
  Hits              8057     8057           
  Misses            4685     4685

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b3874...5b8f996. Read the comment docs.

@abhinavk96 abhinavk96 merged commit 0ab36fd into fossasia:development Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants