feat: Translations Downloads as zip #5624

mrsaicharan1 · 2019-02-20T02:45:23Z

Fixes #5619

Checklist

I have read the Contribution & Best practices Guide and my PR follows them.
My branch is up-to-date with the Upstream development branch.
The unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

Added route for translation downloads
Implemented removal of .zip file as an asynchronous celery task(30mins countdown)

Changes proposed in this pull request:

zip messages.po files and uuid append
Downloading them at the same time
Task for removing the generated zip file as a part of garbage collection

…server into development

app/api/admin_translations.py

codecov · 2019-02-20T03:06:04Z

Codecov Report

Merging #5624 into development will decrease coverage by 0.03%.
The diff coverage is 48%.

@@               Coverage Diff               @@
##           development    #5624      +/-   ##
===============================================
- Coverage        64.31%   64.28%   -0.04%     
===============================================
  Files              273      274       +1     
  Lines            13178    13203      +25     
===============================================
+ Hits              8476     8488      +12     
- Misses            4702     4715      +13

Impacted Files	Coverage Δ
app/__init__.py	`83.81% <100%> (+0.18%)`	⬆️
app/api/helpers/tasks.py	`17.16% <20%> (+0.04%)`	⬆️
app/api/admin_translations.py	`50% <50%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f08b9ab...c7d4429. Read the comment docs.

app/api/admin_translations.py

mrsaicharan1 · 2019-02-22T03:42:43Z

@iamareebjamal Can you please review this?

mrsaicharan1 · 2019-02-22T03:43:56Z

I've kept remove_file under the after_this_request context. Codacy pulls up a coding standard error because of that. @iamareebjamal Any suggestions on how to go about this?

iamareebjamal · 2019-02-23T06:52:14Z

Ignore codacy

iamareebjamal · 2019-02-23T06:53:29Z

app/api/admin_translations.py

+    def remove_file(response):
+        os.remove(os.path.join(app_dir, 'translations.zip'))
+        return response
+    return send_file('translations.zip',  mimetype='application/zip',


Move this line to correct place

@after_this_request is getting skipped if I move the line upwards. You were referring to move the return send_file('translations.zip', mimetype='application/zip', as_attachment=True, attachment_filename='translations.zip'),above @after_this_request, right? Did I get you wrong ?

Yes I was referring to that

Alright, will do it.

app/api/admin_translations.py

iamareebjamal · 2019-03-16T18:42:15Z

How can we obtain a human-readable message to log?

You simply write "Error while deleting translations zip file "

app/api/admin_translations.py

app/api/helpers/tasks.py

Blueprint registration

mrsaicharan1 · 2019-03-25T03:51:51Z

@iamareebjamal Here is the updated PR

app/api/admin_translations.py

app/api/helpers/tasks.py

app/api/admin_translations.py

iamareebjamal · 2019-03-25T19:57:15Z

app/api/admin_translations.py

@@ -13,8 +13,9 @@ def download_translations():
    """Admin Translations Downloads"""
    uuid_literal = uuid.uuid4()
    zip_file = "translations{}".format(uuid_literal)
+    zip_file_ext = zip_file+'.zip'
    shutil.make_archive(zip_file, "zip", translations_dir)


Pass zip_file_ext in this function

Done. Sending a PR right now.

extracted and replaced filenames

mrsaicharan1 · 2019-03-28T05:10:28Z

@CosmicCoder96 Please review.

mrsaicharan1 added 3 commits January 31, 2019 04:42

Additional sessions data added for CSV export

2a65655

Merge branch 'development' of https://github.com/fossasia/open-event-…

1b4e923

…server into development

Merge branch 'development' of https://github.com/fossasia/open-event-…

b855ea1

…server into development

houndci-bot reviewed Feb 20, 2019

View reviewed changes

mrsaicharan1 force-pushed the translations-fix branch from 0c13933 to 9da0b2f Compare February 20, 2019 02:48

houndci-bot reviewed Feb 20, 2019

View reviewed changes

app/api/admin_translations.py Outdated Show resolved Hide resolved

app/api/admin_translations.py Outdated Show resolved Hide resolved

app/api/admin_translations.py Outdated Show resolved Hide resolved

mrsaicharan1 force-pushed the translations-fix branch from 9da0b2f to acabbd0 Compare February 21, 2019 08:07

fossasia deleted a comment Feb 21, 2019

mrsaicharan1 force-pushed the translations-fix branch from acabbd0 to 9e25757 Compare February 21, 2019 21:59

houndci-bot reviewed Feb 21, 2019

View reviewed changes

app/api/admin_translations.py Outdated Show resolved Hide resolved

mrsaicharan1 changed the title ~~Translations fix~~ feat: Translations Downloads as zip Feb 21, 2019

mrsaicharan1 force-pushed the translations-fix branch 2 times, most recently from e709baf to 4bce795 Compare February 21, 2019 22:03

fossasia deleted a comment Feb 21, 2019

iamareebjamal reviewed Feb 23, 2019

View reviewed changes

mrsaicharan1 force-pushed the translations-fix branch from 4bce795 to 4ca9900 Compare February 23, 2019 13:29

houndci-bot reviewed Feb 23, 2019

View reviewed changes

app/api/admin_translations.py Outdated Show resolved Hide resolved

fossasia deleted a comment Mar 16, 2019

iamareebjamal requested changes Mar 16, 2019

View reviewed changes

app/api/admin_translations.py Outdated Show resolved Hide resolved

mrsaicharan1 force-pushed the translations-fix branch 3 times, most recently from cdee44e to 5e83dfc Compare March 18, 2019 16:27

houndci-bot reviewed Mar 18, 2019

View reviewed changes

app/api/helpers/tasks.py Outdated Show resolved Hide resolved

app/api/helpers/tasks.py Outdated Show resolved Hide resolved

app/api/helpers/tasks.py Outdated Show resolved Hide resolved

mrsaicharan1 changed the title ~~feat: Translations Downloads as zip~~ [WIP]feat: Translations Downloads as zip Mar 19, 2019

mrsaicharan1 force-pushed the translations-fix branch from 5e83dfc to 7193460 Compare March 19, 2019 03:54

fossasia deleted a comment Mar 19, 2019

mrsaicharan1 force-pushed the translations-fix branch from 7193460 to b29a47a Compare March 19, 2019 10:24

Translations zip

b29a47a

Blueprint registration

mrsaicharan1 changed the title ~~[WIP]feat: Translations Downloads as zip~~ feat: Translations Downloads as zip Mar 21, 2019

iamareebjamal reviewed Mar 25, 2019

View reviewed changes

app/api/admin_translations.py Outdated Show resolved Hide resolved

iamareebjamal reviewed Mar 25, 2019

View reviewed changes

app/api/helpers/tasks.py Outdated Show resolved Hide resolved

iamareebjamal reviewed Mar 25, 2019

View reviewed changes

app/api/admin_translations.py Outdated Show resolved Hide resolved

iamareebjamal reviewed Mar 25, 2019

View reviewed changes

conflict res

ad34ffe

mrsaicharan1 force-pushed the translations-fix branch from d7c6589 to c23bcfd Compare March 26, 2019 06:22

iamareebjamal approved these changes Mar 26, 2019

View reviewed changes

mrsaicharan1 added 2 commits March 26, 2019 17:22

Logging fix and name extraction

c23bcfd

extracted and replaced filenames

Merge branch 'development' into translations-fix

d29326e

abhinavk96 approved these changes Mar 28, 2019

View reviewed changes

Merge branch 'development' into translations-fix

c7d4429

abhinavk96 approved these changes Mar 28, 2019

View reviewed changes

abhinavk96 merged commit 8a8af7f into fossasia:development Mar 28, 2019

mrsaicharan1 mentioned this pull request Apr 2, 2019

Translations download as zip(.po files) button fix fossasia/open-event-frontend#2445

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Translations Downloads as zip #5624

feat: Translations Downloads as zip #5624

mrsaicharan1 commented Feb 20, 2019 •

edited

codecov bot commented Feb 20, 2019 •

edited

mrsaicharan1 commented Feb 22, 2019

mrsaicharan1 commented Feb 22, 2019

iamareebjamal commented Feb 23, 2019

iamareebjamal Feb 23, 2019

mrsaicharan1 Feb 23, 2019 •

edited

iamareebjamal Feb 23, 2019

mrsaicharan1 Feb 23, 2019

iamareebjamal commented Mar 16, 2019

mrsaicharan1 commented Mar 25, 2019

iamareebjamal Mar 25, 2019

mrsaicharan1 Mar 26, 2019

mrsaicharan1 commented Mar 28, 2019 •

edited

feat: Translations Downloads as zip #5624

feat: Translations Downloads as zip #5624

Conversation

mrsaicharan1 commented Feb 20, 2019 • edited

Checklist

Short description of what this resolves:

Changes proposed in this pull request:

codecov bot commented Feb 20, 2019 • edited

Codecov Report

mrsaicharan1 commented Feb 22, 2019

mrsaicharan1 commented Feb 22, 2019

iamareebjamal commented Feb 23, 2019

iamareebjamal Feb 23, 2019

Choose a reason for hiding this comment

mrsaicharan1 Feb 23, 2019 • edited

Choose a reason for hiding this comment

iamareebjamal Feb 23, 2019

Choose a reason for hiding this comment

mrsaicharan1 Feb 23, 2019

Choose a reason for hiding this comment

iamareebjamal commented Mar 16, 2019

mrsaicharan1 commented Mar 25, 2019

iamareebjamal Mar 25, 2019

Choose a reason for hiding this comment

mrsaicharan1 Mar 26, 2019

Choose a reason for hiding this comment

mrsaicharan1 commented Mar 28, 2019 • edited

mrsaicharan1 commented Feb 20, 2019 •

edited

codecov bot commented Feb 20, 2019 •

edited

mrsaicharan1 Feb 23, 2019 •

edited

mrsaicharan1 commented Mar 28, 2019 •

edited