chore: update sqlchemy dependency

[uds5501]

Fixes #5828

Updates the SQLAlchemy dependency to 1.3.0

[uds5501]

@iamareebjamal How do I resolve the lock conflicts?

[iamareebjamal]

git pull

[iamareebjamal]

Suggested change

	SQLAlchemy>=1.3.0 # 1.2.0 doesn't work, check if any future versions work
	SQLAlchemy>=1.3.0<2.0.0 # 1.2.0 doesn't work, check if any future versions work

[iamareebjamal]

Let the tests run first. They'll most likely fail

[uds5501]

@iamareebjamal Okay few queries, I tried git pull upstream development, no result.

And I have to use pipenv install "SQLAlchemy>=1.3.0<2.0.0", correct?

[iamareebjamal]

Yes, the command is correct.

About git pull upstream development. That seems odd. Pipfile was updated in latest PR, it should be pulled

[uds5501]

@iamareebjamal This is the shell display on git pull

There is no tracking information for the current branch.
Please specify which branch you want to merge with.
See git-pull(1) for details.

    git pull <remote> <branch>

If you wish to set tracking information for this branch you can do so with:

    git branch --set-upstream-to=<remote>/<branch> dependency-update-sqlaclehmy

[iamareebjamal]

I meant git pull upstream development

[iamareebjamal]

Now your PR has conflicts in Pipfile.lock

You should have let the tests run first and if they passed, fix the conflicts

[uds5501]

@iamareebjamal I will move back one commit and push again, that will be fine?

[iamareebjamal]

Build is failing. Please check why

[uds5501]

@iamareebjamal This is happening due to : https://docs.sqlalchemy.org/en/13/changelog/migration_13.html#key-behavioral-changes-orm

As for this particular query, in api/admin_sales/locations.py,

def sales_per_location_by_status(status):
    return db.session.query(
        Event.location_name.label('location'),
        func.sum(Order.amount).label(status + '_sales'),
        func.sum(OrderTicket.quantity).label(status + '_tickets')) \
                     .outerjoin(Order) \
                     .outerjoin(OrderTicket) \
                     .filter(Event.id == Order.event_id) \
                     .filter(Order.status == status) \
                     .group_by(Event.location_name, Order.status) \
                     .cte()

is the issue.

I can change .outerjoin(Order) to .outerjoin(Order, Order.event_id==Event.id) but what do I do about .outerjoin(OrderTicket)?
Shall I use .outerjoin(OrderTicket, OrderTicket.order_id==Order.id)?

[iamareebjamal]

@uds5501 See the previous result and match it after upgrading

[codecov]

Codecov Report

Merging #5902 into development will decrease coverage by <.01%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development    #5902      +/-   ##
===============================================
- Coverage        66.54%   66.53%   -0.01%     
===============================================
  Files              286      286              
  Lines            13919    13921       +2     
===============================================
  Hits              9262     9262              
- Misses            4657     4659       +2

Impacted Files	Coverage Δ
app/api/admin_sales/locations.py	64.1% <ø> (ø)	⬆️
app/api/events.py	26.09% <0%> (-0.16%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba637e3...be1fa36. Read the comment docs.

[uds5501]

@iamareebjamal have a look?

[iamareebjamal]

Great. Please resolve conflicts and I will merge it. Also, remove the comment about SQLAlchemy in requirements.txt