feat: Add is_ticket_form_enabled field #5934
Conversation
Codecov Report
@@ Coverage Diff @@
## development #5934 +/- ##
==============================================
+ Coverage 66.39% 66.4% +<.01%
==============================================
Files 286 286
Lines 13958 13961 +3
==============================================
+ Hits 9268 9271 +3
Misses 4690 4690
Continue to review full report at Codecov.
|
|
@iamareebjamal @shreyanshdwivedi please review |
migrations/versions/0e80c49a6e28_.py
Outdated
| def upgrade(): | ||
| # ### commands auto generated by Alembic - please adjust! ### | ||
| op.add_column('events', sa.Column('is_ticket_form_enabled', sa.Boolean(), server_default='False', nullable=False)) | ||
| op.add_column('events_version', sa.Column('is_ticket_form_enabled', sa.Boolean(), server_default='False', autoincrement=False, nullable=True)) |
There was a problem hiding this comment.
@uds5501 don't you think autoincrement=False should be removed and nullable should be false here?
There was a problem hiding this comment.
@uds5501 What will be the implications of this field being false for the past events? If default is false, then all the events will have ticketing form disabled.
|
@CosmicCoder96 at the moment the order form is created despite the value of this field in the frontend. Although you are right, the default value of this property should be true, we want to have an activated attendee form, I will update this. Also, @shreyanshdwivedi thanks for pointing that out, will be updating that as well |
Fixes #5933
Checklist
developmentbranch.Changes proposed in this pull request: