Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Migration for changing gender type #6117

Merged
merged 9 commits into from Jul 2, 2019
Merged

fix: Migration for changing gender type #6117

merged 9 commits into from Jul 2, 2019

Conversation

kushthedude
Copy link
Member

Fixes #6106

Short description of what this resolves:

  • Migrating gender field type from text to select

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the fix label Jun 27, 2019
@kushthedude
Copy link
Member Author

kushthedude commented Jun 27, 2019 •
edited

@uds5501 @shreyanshdwivedi @iamareebjamal Since this is a manual migration file, Can you please for any potential issue which can be created by it?

@codecov
Copy link

codecov bot commented Jun 27, 2019 •
edited

Codecov Report

Merging #6117 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6117   +/-   ##
============================================
  Coverage        66.37%   66.37%           
============================================
  Files              286      286           
  Lines            14359    14359           
============================================
  Hits              9531     9531           
  Misses            4828     4828

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72ddafb...5212321. Read the comment docs.

abhinavk96
abhinavk96 suggested changes Jun 27, 2019
View reviewed changes
migrations/versions/43e8c59339af_.py Outdated


def upgrade():
op.execute("UPDATE custom_forms SET type = 'select' where field_identifier = 'gender';", execution_options=None)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it more specific, only the form type 'attendee' is being refactored.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CosmicCoder96 @iamareebjamal How do I select the form_type to attendee, Will adding an and form = 'attendee' be suffice or there is some other way?

@kushthedude
Copy link
Member Author

@mrsaicharan1 @shreyanshdwivedi @uds5501 Please Review

@kushthedude
Copy link
Member Author

@iamareebjamal @mrsaicharan1 @CosmicCoder96 @uds5501 Please Review

@iamareebjamal iamareebjamal merged commit f5428b8 into fossasia:development Jul 2, 2019
@kushthedude kushthedude mentioned this pull request Jul 2, 2019
Merged
5 tasks
iamareebjamal pushed a commit to iamareebjamal/open-event-server that referenced this pull request Aug 2, 2019
@kushthedude @iamareebjamal
fix: Migration for changing gender type (fossasia#6117)
05b9e17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi left review comments

@abhinavk96 abhinavk96 abhinavk96 requested changes

@iamareebjamal iamareebjamal iamareebjamal approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write migration file for gender in attendee custom form from text to select
5 participants
@kushthedude @iamareebjamal @abhinavk96 @shreyanshdwivedi @mariobehling