Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow event managers to delete expired orders #6178

Merged
merged 1 commit into from Jul 11, 2019

Conversation

abhinavk96
Copy link
Contributor

Fixes #6177

Short description of what this resolves:

Allows managers to delete expired orders.

@auto-label auto-label bot added the fix label Jul 11, 2019
@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #6178 into development will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6178   +/-   ##
============================================
  Coverage        66.13%   66.13%           
============================================
  Files              288      288           
  Lines            14479    14479           
============================================
  Hits              9575     9575           
  Misses            4904     4904
Impacted Files Coverage Δ
app/api/orders.py 31.02% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f4198...ea24ce0. Read the comment docs.

@iamareebjamal
Copy link
Member

Duplicate of #6172?

@iamareebjamal
Copy link
Member

That PR handles more cases not working. Please confirm and merge that one instead, closing this

@abhinavk96
Copy link
Contributor Author

@iamareebjamal I am not sure how correct that PR is, I think there might be some logical gaps in it, can we merge this as a hotfix, as we have to fix this deletion of expired orders for nextcloud event to revert back by tomorrow, it's a bug fix, PR #6178 seems to implement a new functionality where admin can delete even completed or placed orders -- not sure how refund will work etc.

@abhinavk96 abhinavk96 merged commit ebe5e5b into fossasia:development Jul 11, 2019
iamareebjamal pushed a commit to iamareebjamal/open-event-server that referenced this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organizer/co-organizer/owner cannot delete expired orders
2 participants