Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add required fields for merge of invoices & order models #6196

Merged
merged 1 commit into from Jul 16, 2019

Conversation

mrsaicharan1
Copy link
Member

Fixes #6195

Short description of what this resolves:

  • Added fields for the event invoices in orders

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@mrsaicharan1
Copy link
Member Author

Kept the Event Invoice model as it is to prevent any import breaks. Will refactor it as soon as the payments for event invoices are functional.

@mrsaicharan1
Copy link
Member Author

@iamareebjamal @uds5501 @shreyanshdwivedi Will continue with the additional refactors as soon as this gets reviewed & merged.

@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

Merging #6196 into development will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6196      +/-   ##
===============================================
+ Coverage        65.97%   66.01%   +0.03%     
===============================================
  Files              288      288              
  Lines            14526    14532       +6     
===============================================
+ Hits              9584     9593       +9     
+ Misses            4942     4939       -3
Impacted Files Coverage Δ
app/api/schema/orders.py 89.23% <100%> (+0.34%) ⬆️
app/models/order.py 90.29% <100%> (+0.39%) ⬆️
app/api/helpers/scheduled_jobs.py 24% <0%> (+2.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ea611e...7a9294b. Read the comment docs.

Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goos

Copy link
Member

@prateekj117 prateekj117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamareebjamal iamareebjamal changed the title Added required fields for merge of invoices & order models feat: Add required fields for merge of invoices & order models Jul 16, 2019
@auto-label auto-label bot added the feature label Jul 16, 2019
@iamareebjamal iamareebjamal merged commit a258111 into fossasia:development Jul 16, 2019
@iamareebjamal
Copy link
Member

Please follow semantic PR conventions so that bot can assign a label and hence PR goes to appropriate category in Release Drafter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Foreign keys to Invoice model
5 participants