Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added order foreign keys & relationships in API #6199

Merged
merged 2 commits into from Jul 17, 2019
Merged

feat: Added order foreign keys & relationships in API #6199

merged 2 commits into from Jul 17, 2019

Conversation

mrsaicharan1
Copy link
Member

@mrsaicharan1 mrsaicharan1 commented Jul 16, 2019 •
edited

Fixes #6195

Short description of what this resolves:

Added order foreign keys to invoice model
Add relationship to API

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the feature label Jul 16, 2019
houndci-bot
houndci-bot reviewed Jul 16, 2019
View reviewed changes
app/models/event_invoice.py Outdated Show resolved Hide resolved
app/models/event_invoice.py Outdated Show resolved Hide resolved
@mrsaicharan1 mrsaicharan1 changed the title feat: Added order foreign keys feat: Added order foreign keys to invoice model Jul 16, 2019
@mrsaicharan1 mrsaicharan1 force-pushed the order-fk branch 2 times, most recently from edbda5a to 5eb62d8 Compare July 16, 2019 08:18
@mrsaicharan1 mrsaicharan1 changed the title feat: Added order foreign keys to invoice model [WIP]feat: Added order foreign keys to invoice model Jul 16, 2019
@auto-label auto-label bot removed the feature label Jul 16, 2019
houndci-bot
houndci-bot reviewed Jul 16, 2019
View reviewed changes
app/api/schema/orders.py Outdated Show resolved Hide resolved
app/api/schema/orders.py Outdated Show resolved Hide resolved
app/api/schema/orders.py Outdated Show resolved Hide resolved
app/api/schema/orders.py Outdated Show resolved Hide resolved
app/api/schema/orders.py Outdated Show resolved Hide resolved
app/api/schema/orders.py Outdated Show resolved Hide resolved
houndci-bot
houndci-bot reviewed Jul 16, 2019
View reviewed changes
app/api/schema/event_invoices.py Outdated Show resolved Hide resolved
app/api/schema/event_invoices.py Outdated Show resolved Hide resolved
app/api/schema/event_invoices.py Outdated Show resolved Hide resolved
app/api/schema/event_invoices.py Outdated Show resolved Hide resolved
app/api/schema/event_invoices.py Outdated Show resolved Hide resolved
app/api/schema/event_invoices.py Outdated Show resolved Hide resolved
@mrsaicharan1 mrsaicharan1 changed the title [WIP]feat: Added order foreign keys to invoice model feat: Added order foreign keys to invoice model Jul 16, 2019
@auto-label auto-label bot added the feature label Jul 16, 2019
iamareebjamal
iamareebjamal reviewed Jul 16, 2019
View reviewed changes
app/models/order.py Outdated Show resolved Hide resolved
@mrsaicharan1 mrsaicharan1 force-pushed the order-fk branch 2 times, most recently from eb2ad5a to a39ecbc Compare July 17, 2019 11:39
@mrsaicharan1 mrsaicharan1 changed the title feat: Added order foreign keys to invoice model feat: Added order foreign keys & relationships in API Jul 17, 2019
@mrsaicharan1
Added order foreign keys
62870c4 
New migration

Added relationship in schema

Fixed migration down revision

changed migration

Fixed naming conventions

Fixed naming conventions

Fixed naming conventions
@codecov
Copy link

codecov bot commented Jul 17, 2019 •
edited

Codecov Report

Merging #6199 into development will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6199      +/-   ##
===============================================
+ Coverage        65.95%   65.99%   +0.04%     
===============================================
  Files              288      288              
  Lines            14531    14538       +7     
===============================================
+ Hits              9584     9595      +11     
+ Misses            4947     4943       -4
Impacted Files Coverage Δ
app/api/schema/orders.py 89.06% <100%> (+0.17%) ⬆️
app/api/schema/event_invoices.py 100% <100%> (ø) ⬆️
app/models/order.py 90% <100%> (+0.1%) ⬆️
app/api/__init__.py 100% <100%> (ø) ⬆️
app/models/event_invoice.py 57.53% <100%> (+1.19%) ⬆️
app/api/helpers/scheduled_jobs.py 24.8% <0%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c83c1...a753eae. Read the comment docs.

@mrsaicharan1
Copy link
Member Author

@iamareebjamal @uds5501 @shreyanshdwivedi Please review this.

uds5501
uds5501 approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@uds5501 uds5501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. @iamareebjamal please check

@iamareebjamal iamareebjamal merged commit 7d6399d into fossasia:development Jul 17, 2019
iamareebjamal pushed a commit to iamareebjamal/open-event-server that referenced this pull request Aug 2, 2019
@mrsaicharan1 @iamareebjamal
feat: Added order foreign keys & relationships in API (fossasia#6199)
9c256a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@iamareebjamal iamareebjamal iamareebjamal approved these changes

@uds5501 uds5501 uds5501 approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Foreign keys to Invoice model
5 participants
@mrsaicharan1 @iamareebjamal @houndci-bot @uds5501 @shreyanshdwivedi