Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Refresh Tokens #6204

Merged
merged 7 commits into from Aug 3, 2019

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Jul 16, 2019

Fixes #6168

app/api/helpers/jwt.py Outdated Show resolved Hide resolved
app/api/helpers/jwt.py Outdated Show resolved Hide resolved
app/api/helpers/jwt.py Outdated Show resolved Hide resolved
app/api/helpers/jwt.py Outdated Show resolved Hide resolved
app/api/helpers/jwt.py Outdated Show resolved Hide resolved
app/api/helpers/jwt.py Outdated Show resolved Hide resolved
app/api/helpers/jwt.py Outdated Show resolved Hide resolved
app/api/helpers/jwt.py Outdated Show resolved Hide resolved
app/api/helpers/jwt.py Outdated Show resolved Hide resolved
app/api/helpers/jwt.py Outdated Show resolved Hide resolved
@iamareebjamal iamareebjamal changed the base branch from master to development July 16, 2019 20:54
@iamareebjamal
Copy link
Member Author

iamareebjamal commented Jul 16, 2019

flask_jwt is abandoned. Last update was 4 years ago (2015)

pallets-eco/flask-jwt#123

Should have already shifted to flask-jwt-extended

It is configurable enough that there'll be no breaking change. But even if there is, we'll move ahead with the shifting. Worst thing that can happen is that people will be logged out, which is not bad as they already do every 24 hours

@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

Merging #6204 into development will decrease coverage by 0.09%.
The diff coverage is 50%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #6204     +/-   ##
==============================================
- Coverage        65.54%   65.45%   -0.1%     
==============================================
  Files              286      287      +1     
  Lines            14589    14658     +69     
==============================================
+ Hits              9562     9594     +32     
- Misses            5027     5064     +37
Impacted Files Coverage Δ
app/__init__.py 87.63% <100%> (+0.48%) ⬆️
app/api/helpers/auth.py 70% <33.33%> (-22%) ⬇️
app/api/auth.py 24.03% <35.89%> (+0.27%) ⬆️
app/api/users.py 31.13% <50%> (-0.19%) ⬇️
app/models/user_token_blacklist.py 75% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fc0c20...bc45bf3. Read the comment docs.

app/api/auth.py Outdated Show resolved Hide resolved
app/api/auth.py Outdated Show resolved Hide resolved
@fossasia fossasia deleted a comment Aug 2, 2019
@fossasia fossasia deleted a comment Aug 2, 2019
@fossasia fossasia deleted a comment Aug 2, 2019
@fossasia fossasia deleted a comment Aug 2, 2019
@iamareebjamal iamareebjamal changed the title WIP: Implement Refresh Tokens feat: Implement Refresh Tokens Aug 2, 2019
@auto-label auto-label bot added the feature label Aug 2, 2019
app/api/auth.py Outdated Show resolved Hide resolved
app/api/auth.py Outdated Show resolved Hide resolved
app/api/auth.py Outdated Show resolved Hide resolved
app/api/auth.py Show resolved Hide resolved
tests/all/unit/api/helpers/test_utilities.py Outdated Show resolved Hide resolved
app/models/user_token_blacklist.py Outdated Show resolved Hide resolved
app/factories/setting.py Outdated Show resolved Hide resolved
app/api/helpers/auth.py Outdated Show resolved Hide resolved
app/api/auth.py Outdated Show resolved Hide resolved
app/api/auth.py Outdated Show resolved Hide resolved
app/api/__init__.py Outdated Show resolved Hide resolved
@fossasia fossasia deleted a comment Aug 2, 2019
@fossasia fossasia deleted a comment Aug 2, 2019
@fossasia fossasia deleted a comment Aug 2, 2019
@fossasia fossasia deleted a comment Aug 2, 2019
@fossasia fossasia deleted a comment Aug 2, 2019
app/api/auth.py Outdated Show resolved Hide resolved
@iamareebjamal iamareebjamal merged commit 15ba9e4 into fossasia:development Aug 3, 2019
@iamareebjamal iamareebjamal deleted the refresh-token branch August 3, 2019 08:33
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Aug 9, 2019
* feat: Implement blacklisting and fresh token

* Reduce expiry for refresh based token
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API implementation for Token Refresh
2 participants