Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle padding error for verification token #6206

Merged
merged 2 commits into from Jul 17, 2019

Conversation

uds5501
Copy link
Contributor

@uds5501 uds5501 commented Jul 17, 2019

Fixes #6167

Short description of what this resolves:

Throws invalid token error for any base64 error

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

app/api/auth.py Outdated Show resolved Hide resolved
@auto-label auto-label bot added the fix label Jul 17, 2019
app/api/auth.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

Merging #6206 into development will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6206      +/-   ##
===============================================
- Coverage        65.99%   65.95%   -0.05%     
===============================================
  Files              288      288              
  Lines            14528    14531       +3     
===============================================
- Hits              9588     9584       -4     
- Misses            4940     4947       +7
Impacted Files Coverage Δ
app/api/auth.py 23.88% <0%> (-0.28%) ⬇️
app/api/helpers/scheduled_jobs.py 21.6% <0%> (-3.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b54d2a...5700d6b. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 23c83c1 into fossasia:development Jul 17, 2019
iamareebjamal pushed a commit to iamareebjamal/open-event-server that referenced this pull request Aug 2, 2019
* handle padding error

* catch specific base64 error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal server error during email verification
7 participants