Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restoration of deleted event #6218

Merged
merged 1 commit into from Jul 24, 2019

Conversation

shreyanshdwivedi
Copy link
Member

Fixes #6147

Short description of what this resolves:

Restoration of a deleted event fails

Changes proposed in this pull request:

  • Removes validate_date on event schema
  • Adds a function validate_event as programmatic check
  • Skips validation of date on the update of deleted events

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

app/api/events.py Outdated Show resolved Hide resolved
@auto-label auto-label bot added the fix label Jul 20, 2019
@shreyanshdwivedi shreyanshdwivedi force-pushed the dateValidation branch 2 times, most recently from 4e6e264 to a94413f Compare July 20, 2019 10:13
@codecov
Copy link

codecov bot commented Jul 20, 2019

Codecov Report

Merging #6218 into development will decrease coverage by 0.14%.
The diff coverage is 12.5%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6218      +/-   ##
===============================================
- Coverage        65.86%   65.71%   -0.15%     
===============================================
  Files              287      286       -1     
  Lines            14559    14523      -36     
===============================================
- Hits              9589     9544      -45     
- Misses            4970     4979       +9
Impacted Files Coverage Δ
app/api/schema/events.py 91.72% <ø> (+1.79%) ⬆️
app/api/events.py 25.13% <12.5%> (-0.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc02893...d851f21. Read the comment docs.

@iamareebjamal
Copy link
Member

Have a peer review

@shreyanshdwivedi
Copy link
Member Author

@mrsaicharan1 @uds5501 @kushthedude please review

fixes hound issue

adds an event field to the function
@shreyanshdwivedi
Copy link
Member Author

@uds5501 @mrsaicharan1 pleas review

@iamareebjamal iamareebjamal merged commit 100ad5b into fossasia:development Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleted Event Restoration fails
4 participants