Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unverified user can buy free tickets #6294

Merged
merged 3 commits into from Aug 5, 2019
Merged

fix: Unverified user can buy free tickets #6294

merged 3 commits into from Aug 5, 2019

Conversation

kushthedude
Copy link
Member

Fixes #6293

@auto-label auto-label bot added the fix label Aug 2, 2019
@kushthedude
Copy link
Member Author

@shreyanshdwivedi @uds5501 @mrsaicharan1 Please REview

@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #6294 into development will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6294      +/-   ##
===============================================
- Coverage        65.32%   65.32%   -0.01%     
===============================================
  Files              287      287              
  Lines            14695    14704       +9     
===============================================
+ Hits              9600     9605       +5     
- Misses            5095     5099       +4
Impacted Files Coverage Δ
app/api/attendees.py 37.77% <ø> (+0.55%) ⬆️
app/api/orders.py 28.75% <0%> (-0.74%) ⬇️
app/api/helpers/scheduled_jobs.py 24.6% <0%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1fae56...510145d. Read the comment docs.

@kushthedude
Copy link
Member Author

@iamareebjamal Please review

@kushthedude
Copy link
Member Author

@iamareebjamal Please review

@fossasia fossasia deleted a comment Aug 3, 2019
@iamareebjamal
Copy link
Member

PRF

@kushthedude
Copy link
Member Author

PRF

Pseudo-Random Function 😄 ?

@iamareebjamal
Copy link
Member

Peer review first

@kushthedude
Copy link
Member Author

@uds5501 @shreyanshdwivedi @mrsaicharan1 Please Review

Copy link
Member

@shreyanshdwivedi shreyanshdwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fossasia fossasia deleted a comment Aug 4, 2019
@kushthedude
Copy link
Member Author

@iamareebjamal Please Review

@iamareebjamal
Copy link
Member

Build is failing

@kushthedude
Copy link
Member Author

kushthedude commented Aug 5, 2019 via email

@iamareebjamal iamareebjamal merged commit 58747ec into fossasia:development Aug 5, 2019
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow unverified user to buy Free Ticket
4 participants