Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deleted events from cron actions #6295

Merged
merged 1 commit into from Aug 3, 2019

Conversation

uds5501
Copy link
Contributor

@uds5501 uds5501 commented Aug 2, 2019

Fixes fossasia/open-event-frontend#3346

Changes proposed in this pull request:

  • Removes deleted events from cron actions like sending email after completion.

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #6295 into development will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6295   +/-   ##
============================================
  Coverage        65.54%   65.54%           
============================================
  Files              286      286           
  Lines            14589    14589           
============================================
  Hits              9562     9562           
  Misses            5027     5027
Impacted Files Coverage Δ
app/api/helpers/scheduled_jobs.py 21.42% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fc0c20...988d77a. Read the comment docs.

@uds5501
Copy link
Contributor Author

uds5501 commented Aug 2, 2019

@iamareebjamal done

@iamareebjamal iamareebjamal merged commit c3b93b8 into fossasia:development Aug 3, 2019
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleted draft event results in notifications and shows up in draft on admin
2 participants