feat: Implemented routes for creation & charging(invoice) through PayPal #6296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 3, 2019
mrsaicharan1
force-pushed
the
paypal-invoice
branch
2 times, most recently
from
c2449ea
to
fec1d40
Compare
houndci-bot
reviewed
Aug 3, 2019
mrsaicharan1
force-pushed
the
paypal-invoice
branch
2 times, most recently
from
37c18d6
to
14a4223
Compare
Codecov Report
@@ Coverage Diff @@
## development #6296 +/- ##
==============================================
Coverage ? 65.33%
==============================================
Files ? 287
Lines ? 14765
Branches ? 0
==============================================
Hits ? 9646
Misses ? 5119
Partials ? 0
Continue to review full report at Codecov.
|
houndci-bot
reviewed
Aug 3, 2019
| event_invoice.status = 'completed' | ||
| event_invoice.transaction_id = paypal_payment_id | ||
| event_invoice.completed_at = datetime.utcnow() | ||
| save_to_db(event_invoice) |
| event_invoice = safe_query(db, EventInvoice, 'identifier', invoice_identifier, 'identifier') | ||
| # save the paypal payment_id with the order | ||
| event_invoice.paypal_token = paypal_payment_id | ||
| save_to_db(event_invoice) |
mrsaicharan1
force-pushed
the
paypal-invoice
branch
from
506a1a3
to
548f148
Compare
mrsaicharan1
force-pushed
the
paypal-invoice
branch
from
548f148
to
b8d0fa4
Compare
houndci-bot
reviewed
Aug 14, 2019
mrsaicharan1
force-pushed
the
paypal-invoice
branch
from
fbd04dd
to
231ca61
Compare
5 tasks
mrsaicharan1
force-pushed
the
paypal-invoice
branch
from
29581c6
to
5fb14dd
Compare
uds5501
previously approved these changes
Aug 14, 2019
mrsaicharan1
force-pushed
the
paypal-invoice
branch
from
5fb14dd
to
3470ba1
Compare
|
@uds5501 Yes, I've resolved the error. Travis timed out previously. Please review now. |
uds5501
approved these changes
Aug 16, 2019
|
@iamareebjamal I've tested this properly. This is ready for a review. |
shreyanshdwivedi
approved these changes
Aug 16, 2019
iamareebjamal
approved these changes
Aug 16, 2019
iamareebjamal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6245
https://drive.google.com/file/d/14Je8183BW4wgToQJCihp7C_k0MScbBjA/view?usp=sharing
Short description of what this resolves:
Implements create payment & charge routes for authorization of event invoice payments.
Related FE PR:fossasia/open-event-frontend#3351
Changes proposed in this pull request:
Checklist
developmentbranch.