Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid check if email is overridden #6299

Merged
merged 1 commit into from Aug 3, 2019

Conversation

shreyanshdwivedi
Copy link
Member

Fixes #6298
Follow-up PR for fossasia/open-event-frontend#3352

Short description of what this resolves:

When email is overridden, a check is still being called and is-email-overridden missing in docs

Changes proposed in this pull request:

  • fix check
  • add is-email-overridden to docs

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the fix label Aug 3, 2019
app/api/speakers.py Outdated Show resolved Hide resolved
@shreyanshdwivedi
Copy link
Member Author

@iamareebjamal please review

@fossasia fossasia deleted a comment Aug 3, 2019
@codecov
Copy link

codecov bot commented Aug 3, 2019

Codecov Report

Merging #6299 into development will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6299   +/-   ##
============================================
  Coverage        65.45%   65.45%           
============================================
  Files              287      287           
  Lines            14661    14661           
============================================
  Hits              9596     9596           
  Misses            5065     5065
Impacted Files Coverage Δ
app/api/speakers.py 47.87% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15ba9e4...b9a6253. Read the comment docs.

@iamareebjamal iamareebjamal merged commit aefd480 into fossasia:development Aug 3, 2019
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing condition to avoid speaker email check on being overridden
2 participants