Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use from email name for sendgrid emails #6324

Merged
merged 1 commit into from Aug 7, 2019

Conversation

abhinavk96
Copy link
Contributor

@abhinavk96 abhinavk96 commented Aug 6, 2019

Fixes #6306

Ensures from email name is used while sending out mails via sendgrid. Tested as working.

@auto-label auto-label bot added the fix label Aug 6, 2019
@abhinavk96 abhinavk96 requested review from iamareebjamal and shreyanshdwivedi and removed request for iamareebjamal August 6, 2019 19:27
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #6324 into development will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6324      +/-   ##
===============================================
+ Coverage        65.29%   65.32%   +0.02%     
===============================================
  Files              287      287              
  Lines            14704    14704              
===============================================
+ Hits              9601     9605       +4     
+ Misses            5103     5099       -4
Impacted Files Coverage Δ
app/api/helpers/tasks.py 17.56% <0%> (ø) ⬆️
app/api/helpers/scheduled_jobs.py 24.6% <0%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5949dc6...2c76040. Read the comment docs.

@iamareebjamal iamareebjamal changed the title fix: use fromEmailName for sendgrid emails fix: use from email eame for sendgrid emails Aug 7, 2019
@iamareebjamal iamareebjamal changed the title fix: use from email eame for sendgrid emails fix: use from email name for sendgrid emails Aug 7, 2019
@iamareebjamal iamareebjamal merged commit c5b6eff into fossasia:development Aug 7, 2019
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emails: Not showing "from Name" specified in admin settings
3 participants