fix: Return only accepted session and public speaker call by default #6328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamareebjamal
requested changes
Aug 7, 2019
| @@ -86,20 +86,29 @@ def before_get_object(self, view_kwargs): | |||
| """ | |||
| if view_kwargs.get('event_identifier'): | |||
| try: | |||
| event = self.session.query(Event).filter_by(identifier=view_kwargs['event_identifier']).one() | |||
| event = self.session.query(Event).filter_by(identifier=view_kwargs['event_identifier'], | |||
| privacy='public').one() | |||
There was a problem hiding this comment.
@iamareebjamal Speaker calls are an invitation to submit a proposal for being a speaker at the event. They are either private or public. I didn't get the context of accepted here. Did you mean making changes for speakers to only return accepted speakers?
Codecov Report
@@ Coverage Diff @@
## development #6328 +/- ##
===============================================
- Coverage 65.24% 65.22% -0.03%
===============================================
Files 287 287
Lines 14731 14736 +5
===============================================
Hits 9611 9611
- Misses 5120 5125 +5
Continue to review full report at Codecov.
|
prateekj117
changed the title
iamareebjamal
approved these changes
Aug 9, 2019
abhinavk96
added a commit
that referenced
this pull request
Aug 13, 2019
)" This reverts commit 3987cd3.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5998
Checklist
developmentbranch.