Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Implement nested tables in order invoice details #6329

Merged
merged 2 commits into from Aug 8, 2019

Conversation

uds5501
Copy link
Contributor

@uds5501 uds5501 commented Aug 8, 2019

Fixes #6119

Short description of what this resolves:

Implement Nested tables for billing details column to ensure long names don't overflow.

Screenshot from 2019-08-08 09-43-23

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the fix label Aug 8, 2019
@uds5501
Copy link
Contributor Author

uds5501 commented Aug 8, 2019

@iamareebjamal @shreyanshdwivedi @mrsaicharan1
Review Please!

@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #6329 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6329   +/-   ##
============================================
  Coverage        65.26%   65.26%           
============================================
  Files              287      287           
  Lines            14713    14713           
============================================
  Hits              9602     9602           
  Misses            5111     5111

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e390b56...dca5b95. Read the comment docs.

@iamareebjamal iamareebjamal merged commit d5721d8 into fossasia:development Aug 8, 2019
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order Invoice PDF not suitable for long names and addresses
3 participants