Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add can_pay_by_paytm to event model and schema and refactor other keys #6349

Merged
merged 1 commit into from Aug 13, 2019

Conversation

shreyanshdwivedi
Copy link
Member

Fixes #6340

Short description of what this resolves:

Adds can_pay_by_paytm to event model and schema

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the feature label Aug 12, 2019
@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #6349 into development will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6349      +/-   ##
===============================================
+ Coverage        65.38%   65.39%   +<.01%     
===============================================
  Files              287      287              
  Lines            14726    14729       +3     
===============================================
+ Hits              9629     9632       +3     
  Misses            5097     5097
Impacted Files Coverage Δ
app/api/schema/events.py 91.85% <100%> (+0.06%) ⬆️
app/models/event.py 78.64% <100%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dca10e...43b2f22. Read the comment docs.

@shreyanshdwivedi shreyanshdwivedi force-pushed the canPayByPaytm branch 2 times, most recently from fc9e1c0 to 1e80187 Compare August 13, 2019 08:00
@shreyanshdwivedi shreyanshdwivedi changed the title feat: add can_pay_by_paytm to event model and schema feat: add can_pay_by_paytm to event model and schema and refactor other keys Aug 13, 2019
@fossasia fossasia deleted a comment Aug 13, 2019
@shreyanshdwivedi
Copy link
Member Author

@uds5501 @mrsaicharan1 @kushthedude please review

uds5501
uds5501 previously approved these changes Aug 13, 2019
Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change revises in migration

refactors other payment keys

updates the down_migration
@shreyanshdwivedi
Copy link
Member Author

@iamareebjamal @mrsaicharan1 @uds5501 updated the down_revision and revises
Please take a look

@iamareebjamal iamareebjamal merged commit 99d9694 into fossasia:development Aug 13, 2019
@fossasia fossasia deleted a comment Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add paytm variables to event model
5 participants