feat: Support for non-attachment mails #6370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsaicharan1
force-pushed
the
sendit
branch
3 times, most recently
from
7cf5e56
to
61ff368
Compare
mrsaicharan1
changed the title
|
@uds5501 @iamareebjamal This is ready for a review |
Codecov Report
@@ Coverage Diff @@
## development #6370 +/- ##
===============================================
- Coverage 65.33% 65.29% -0.04%
===============================================
Files 287 287
Lines 14765 14775 +10
===============================================
+ Hits 9646 9647 +1
- Misses 5119 5128 +9
Continue to review full report at Codecov.
|
houndci-bot
reviewed
Aug 16, 2019
app/api/helpers/tasks.py
Outdated
| message.attach(name=attachment) | ||
| mailer.send(message) | ||
| logging.info('Message sent via SMTP') | ||
|
|
mrsaicharan1
force-pushed
the
sendit
branch
2 times, most recently
from
a9178f2
to
cdda896
Compare
Shifted logic to outer try..except Supported for SMTP protocol
iamareebjamal
approved these changes
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6047
Fixes #6327
Short description of what this resolves:
This PR aims to enable the mail task to send emails even when attachments are blocked by the mail server.
Changes proposed in this pull request: