Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error and pointer for unverified user buying free tickets #6395

Merged

Conversation

shreyanshdwivedi
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi commented Aug 19, 2019

Fixes #6394

Short description of what this resolves:

Wrong error and pointer for unverified user

Changes proposed in this pull request:

  • changes pointer from order to user
  • changes error to ForbiddenException and changes error message
{
  "errors": [{
     "status": 403, 
     "source": {
          "pointer": "/data/relationships/user", 
          "code": "unverified-user"
      }, 
      "title": "Access Forbidden", 
      "detail": "Unverified user cannot place free orders"
   }], 
   "jsonapi": {"version": "1.0"}
}

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the fix label Aug 19, 2019
@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #6395 into development will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6395      +/-   ##
===============================================
+ Coverage        65.16%   65.19%   +0.02%     
===============================================
  Files              287      287              
  Lines            14810    14810              
===============================================
+ Hits              9651     9655       +4     
+ Misses            5159     5155       -4
Impacted Files Coverage Δ
app/api/orders.py 27.91% <0%> (ø) ⬆️
app/api/helpers/scheduled_jobs.py 24.03% <0%> (+3.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcf5275...66803a5. Read the comment docs.

app/api/orders.py Outdated Show resolved Hide resolved
@iamareebjamal iamareebjamal merged commit 622ae4f into fossasia:development Aug 20, 2019
@shreyanshdwivedi shreyanshdwivedi deleted the freeTicketError branch August 21, 2019 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong error and pointer for unverified user
2 participants