Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add workaround for multiprocess engine forking #6499

Merged

Conversation

iamareebjamal
Copy link
Member

No description provided.


# https://docs.sqlalchemy.org/en/13/faq/connections.html#how-do-i-use-engines-connections-sessions-with-python-multiprocessing-or-os-fork
def add_engine_pidguard(engine):
from sqlalchemy import event, exc # placed here for import conflict resolution

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least two spaces before inline comment

@auto-label auto-label bot added the fix label Oct 3, 2019
@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #6499 into development will increase coverage by 0.01%.
The diff coverage is 81.25%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6499      +/-   ##
===============================================
+ Coverage        64.52%   64.54%   +0.01%     
===============================================
  Files              292      292              
  Lines            15127    15142      +15     
===============================================
+ Hits              9761     9773      +12     
- Misses            5366     5369       +3
Impacted Files Coverage Δ
app/__init__.py 87.89% <100%> (+0.06%) ⬆️
app/models/__init__.py 84.21% <78.57%> (-15.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3d3733...6dedb65. Read the comment docs.

@iamareebjamal iamareebjamal merged commit b0ce70e into fossasia:development Oct 4, 2019
@iamareebjamal iamareebjamal deleted the multiprocess-sqla branch October 4, 2019 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants