Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Add CircleCI Build Status Badge #6531

Merged
merged 1 commit into from Oct 17, 2019
Merged

chore(docs): Add CircleCI Build Status Badge #6531

merged 1 commit into from Oct 17, 2019

Conversation

rbstrachan
Copy link
Contributor

@rbstrachan rbstrachan commented Oct 17, 2019

I was able to find CircleCI's own badge however the resolution of the svg file was too low, so I opted for the flat badge, generated at shields.io, instead.

I would also like to point out that I noticed the "Deploy To Docker Cloud" link in the #installation section is not displayed correctly, however, I could not find another appropriate image to replace it.

Fixes #6527

Short description of what this resolves:

  • Add CircleCI Build Status badge to README.md

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

- Added CircleCI Build Status badge, generated at [shields.io](https://www.shields.io/).

I was able to find CircleCI's [own badge](https://www.circleci.com/gh/fossasia/open-event-server.svg) however the resolution of the `svg` file was too low, so I opted for the flat badge instead.

I would also like to point out that I noticed the "Deploy To Docker Cloud" link in the [#installation](https://github.com/fossasia/open-event-server#installation) section is not displayed correctly, however, I could not find another appropriate image to replace it.
@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #6531 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           development   #6531   +/-   ##
===========================================
  Coverage         64.9%   64.9%           
===========================================
  Files              294     294           
  Lines            15199   15199           
===========================================
  Hits              9865    9865           
  Misses            5334    5334

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95eb0cb...eace64d. Read the comment docs.

@kushthedude
Copy link
Member

I would also like to point out that I noticed the "Deploy To Docker Cloud" link in the #installation section is not displayed correctly, however, I could not find another appropriate image to replace it.

Docker SVG is invalid, Open a relevant issue and check if you can find the replacement.

@iamareebjamal iamareebjamal changed the title Add CircleCI Build Status Badge chore(docs): Add CircleCI Build Status Badge Oct 17, 2019
@auto-label auto-label bot added the docs label Oct 17, 2019
@iamareebjamal iamareebjamal merged commit 21b7fad into fossasia:development Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CircleCI Badge
4 participants