Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Update README.md for python 3.7 #6535

Merged
merged 2 commits into from Oct 18, 2019

Conversation

chiral-carbon
Copy link
Contributor

Fixes #6520

Short description of what this resolves:

Updated README.md to reflect that open-event-server now runs on python 3.7.

Changes proposed in this pull request:

  • Documentation fix.

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@chiral-carbon
Copy link
Contributor Author

@prateekj117 @iamareebjamal please review.

@iamareebjamal
Copy link
Member

iamareebjamal commented Oct 18, 2019

Please search elsewhere as well, if we have written python < 3.7

@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #6535 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6535   +/-   ##
============================================
  Coverage        65.11%   65.11%           
============================================
  Files              295      295           
  Lines            15284    15284           
============================================
  Hits              9952     9952           
  Misses            5332     5332

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec037fa...a65e10e. Read the comment docs.

@chiral-carbon
Copy link
Contributor Author

chiral-carbon commented Oct 18, 2019

@iamareebjamal I can't find <python 3.7 mentioned anywhere else in README.md or the installation docs. But should I change python 3 in the requirements in the installation md files as mentioned here to python 3.7?

@chiral-carbon
Copy link
Contributor Author

@iamareebjamal please check.

@iamareebjamal iamareebjamal changed the title Update README.md for python 3.7 chore(docs): Update README.md for python 3.7 Oct 18, 2019
@auto-label auto-label bot added the docs label Oct 18, 2019
@iamareebjamal iamareebjamal merged commit d781989 into fossasia:development Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs to python 3.7
2 participants