Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change association table name to ticket_tagging #6536

Merged

Conversation

prateekj117
Copy link
Member

Fixes #6389

Short description of what this resolves:

Change the association table name to change to something obvious according to its functionality.

Changes proposed in this pull request:

  • Change the association table name to ticket_tagging as it is used to identify which ticket_tag_id is associated with which ticket.

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the fix label Oct 18, 2019
@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #6536 into development will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6536   +/-   ##
============================================
  Coverage        65.12%   65.12%           
============================================
  Files              296      296           
  Lines            15292    15292           
============================================
  Hits              9959     9959           
  Misses            5333     5333
Impacted Files Coverage Δ
app/models/ticket.py 73.19% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e6bfa...5e64156. Read the comment docs.

@prateekj117
Copy link
Member Author

@iamareebjamal please review.

@iamareebjamal
Copy link
Member

Approved, but not merging as release has been freezed

@prateekj117
Copy link
Member Author

@iamareebjamal I think we can merge this as well now.

@iamareebjamal
Copy link
Member

Don't merge branches unless there are conflicts. Tests are run again without any reason and then we have to wait before merging

@prateekj117
Copy link
Member Author

@iamareebjamal Ok will keep that in mind.

@iamareebjamal iamareebjamal merged commit 1c7934a into fossasia:development Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename association table to a proper name
2 participants