Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Checks for is_email_overridden not working #6566

Merged

Conversation

prateekj117
Copy link
Member

@prateekj117 prateekj117 commented Nov 2, 2019

Fixes #6565

Short description of what this resolves:

Checks for is_email_overridden not working.

Changes proposed in this pull request:

  • Change spelling of is_email_overriden to is_email_overridden

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the fix label Nov 2, 2019
@prateekj117
Copy link
Member Author

@iamareebjamal Please review.

@codecov
Copy link

codecov bot commented Nov 2, 2019

Codecov Report

Merging #6566 into development will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6566   +/-   ##
============================================
  Coverage        65.03%   65.03%           
============================================
  Files              296      296           
  Lines            15248    15248           
============================================
  Hits              9916     9916           
  Misses            5332     5332
Impacted Files Coverage Δ
app/api/speakers.py 47.87% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c9e054...dab2279. Read the comment docs.

@iamareebjamal
Copy link
Member

If all of this was backed by tests, these silly mistakes won't happen :(

@iamareebjamal iamareebjamal merged commit c4fe295 into fossasia:development Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call for Speakers Signup Form: "Don't require this email" possible for everyone
2 participants