Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Fix grammatical mistakes in docs #6568

Merged
merged 1 commit into from Nov 3, 2019

Conversation

nnrepos
Copy link
Contributor

@nnrepos nnrepos commented Nov 2, 2019

fixes #6552

Short description of what this resolves:

This PR replaces the text:
Go the directory where your postgres file is stored.
inside docs/installation/local.md, with the text:
Go to the directory where your postgres file is stored.
In short, it corrects a grammar mistake.
For more information, read this.

@codecov
Copy link

codecov bot commented Nov 2, 2019

Codecov Report

Merging #6568 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6568   +/-   ##
============================================
  Coverage        65.03%   65.03%           
============================================
  Files              296      296           
  Lines            15248    15248           
============================================
  Hits              9916     9916           
  Misses            5332     5332

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73538a8...18dfb7b. Read the comment docs.

@prateekj117
Copy link
Member

prateekj117 commented Nov 2, 2019

@nnrepos Great to see you want to contribute here but it would be great if you could just give a more apt description of what this PR resolves. Though this PR doesn't need much description, these are things that should be followed. It can save a heck of reviewer's time and a lot of unnecessary discussion on the PR.

@nnrepos
Copy link
Contributor Author

nnrepos commented Nov 2, 2019

@prateekj117
This PR replaces the text:
Go the directory where your postgres file is stored.
inside docs/installation/local.md, with the text:
Go to the directory where your postgres file is stored.
In short, it corrects a grammar mistake.
For more information, read this.

@prateekj117
Copy link
Member

@nnrepos Description should be along with the other information about the PR like what issue it fixes, etc. I am not the only reviewer here.

@nnrepos
Copy link
Contributor Author

nnrepos commented Nov 2, 2019

@nnrepos Description should be along with the other information about the PR like what issue it fixes, etc. I am not the only reviewer here.

I've corrected it. Is it ok now?

@prateekj117
Copy link
Member

@nnrepos Remove a great description of the PR is already in the issue itself, so I won't elaborate here.
Also, it seems like you wanted to use hyperlink somewhere but didn't.

@nnrepos
Copy link
Contributor Author

nnrepos commented Nov 2, 2019

@nnrepos Remove a great description of the PR is already in the issue itself, so I won't elaborate here.
Also, it seems like you wanted to use hyperlink somewhere but didn't.

fixed

@prateekj117
Copy link
Member

@iamareebjamal LGTM.

@iamareebjamal
Copy link
Member

Change the PR title

@nnrepos nnrepos changed the title Update local.md fix grammar mistake in docs/installation/local.md Nov 3, 2019
@nnrepos
Copy link
Contributor Author

nnrepos commented Nov 3, 2019

@iamareebjamal done

@iamareebjamal iamareebjamal changed the title fix grammar mistake in docs/installation/local.md chore(docs): Fix grammatical mistakes in docs Nov 3, 2019
@auto-label auto-label bot added the docs label Nov 3, 2019
@iamareebjamal iamareebjamal merged commit 701eec5 into fossasia:development Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: Grammatical mistake in documentation for local installation
4 participants