New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Check if identifier does not contain of all digits. #6572
fix: Check if identifier does not contain of all digits. #6572
Conversation
Codecov Report
@@ Coverage Diff @@
## development #6572 +/- ##
===============================================
+ Coverage 65.03% 65.03% +<.01%
===============================================
Files 296 296
Lines 15248 15247 -1
===============================================
Hits 9916 9916
+ Misses 5332 5331 -1
Continue to review full report at Codecov.
|
@iamareebjamal As you told on Gitter that you have appended |
Not everyone who has open event server will have done it, so we need to handle it Make a script which goes through events which have digit identifier and updates their identifier So, that we can add in release note to just run |
@iamareebjamal Done. Please review. |
@@ -37,6 +37,15 @@ def add_event_identifier(): | |||
save_to_db(event) | |||
|
|||
|
|||
@manager.command | |||
def fix_digit_identifier(): | |||
events = Event.query.filter(Event.identifier.op('~')('^[0-9\.]+$')).all() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invalid escape sequence '.'
@iamareebjamal Please review. |
@iamareebjamal Done. |
Add the command in CHANGELOG.md to be run for correcting the identifiers |
@iamareebjamal Done. |
Fixes #6423
Short description of what this resolves:
The public event page does not open in case the identifier of the event contains all digits.
Checklist
development
branch.