Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Add missing attendee endpoints #6596

Merged
merged 1 commit into from Nov 16, 2019
Merged

chore(docs): Add missing attendee endpoints #6596

merged 1 commit into from Nov 16, 2019

Conversation

akshat0047
Copy link
Member

Fixes #6591

Short description of what this resolves:

Add four endpoints mentioned in the issue to the API Docs

Changes proposed in this pull request:

  • added endpoints in attendee api doc

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

}
}

## List Attendees under an user [/v1/users/{user_id}/attendees]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not useful. This should not even be available

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this can be of use in the admin section in listing the participated events of a user, can be included in the issue #6595

@akshat0047
Copy link
Member Author

akshat0047 commented Nov 15, 2019

Actually Circle CI for three of them is failing, with dialogue object not found event_id, ticket_id etc. but they're possible with postman. Inspecting it.

@codecov
Copy link

codecov bot commented Nov 15, 2019

Codecov Report

Merging #6596 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6596   +/-   ##
============================================
  Coverage        65.03%   65.03%           
============================================
  Files              296      296           
  Lines            15247    15247           
============================================
  Hits              9916     9916           
  Misses            5331     5331

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3a8c33...0cb82c8. Read the comment docs.

@akshat0047
Copy link
Member Author

akshat0047 commented Nov 15, 2019

When there is no attendee on event_id or ticket_id in circleci db, dred tests will always fail with object not found. I see the api point for event detail for event_id 1 as working though. Is it meant to be like this or I have to make corrections

@iamareebjamal
Copy link
Member

Read about dredd hooks

@akshat0047
Copy link
Member Author

Yeah, I made it, Dredd confused me in the issues, now I know it.

@iamareebjamal iamareebjamal changed the title Fix: Added missing endpoints chore(docs): Added missing attendee endpoints Nov 16, 2019
@auto-label auto-label bot added the docs label Nov 16, 2019
@iamareebjamal iamareebjamal changed the title chore(docs): Added missing attendee endpoints chore(docs): Add missing attendee endpoints Nov 16, 2019
@iamareebjamal iamareebjamal merged commit bb504da into fossasia:development Nov 16, 2019
codedsun pushed a commit to codedsun/open-event-server that referenced this pull request Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing end-points to the API docs
2 participants