fix: handelled invalid price value in paid tickets #6604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #6604 +/- ##
===============================================
- Coverage 65.03% 65.02% -0.01%
===============================================
Files 296 296
Lines 15247 15250 +3
===============================================
+ Hits 9916 9917 +1
- Misses 5331 5333 +2
Continue to review full report at Codecov.
|
|
@iamareebjamal @prateekj117 Please check |
prateekj117
suggested changes
Nov 18, 2019
app/api/schema/tickets.py
Outdated
| @@ -67,6 +67,12 @@ def validate_quantity(self, data): | |||
| raise UnprocessableEntity({'pointer': '/data/attributes/quantity'}, | |||
| "quantity should be greater than or equal to max-order") | |||
|
|
|||
| @validates_schema | |||
| def validate_price(self, data): | |||
| if data['type'] == 'paid' and ('price' not in data or not isinstance(data['price'], float)): | |||
There was a problem hiding this comment.
No need to check for the data type of data['price']. Also, make sure that a paid ticket has a price > 0.
There was a problem hiding this comment.
ok! adding the check
houndci-bot
reviewed
Nov 18, 2019
app/api/schema/tickets.py
Outdated
| @@ -67,6 +67,12 @@ def validate_quantity(self, data): | |||
| raise UnprocessableEntity({'pointer': '/data/attributes/quantity'}, | |||
| "quantity should be greater than or equal to max-order") | |||
|
|
|||
| @validates_schema | |||
| def validate_price(self, data): | |||
| if data['type'] == 'paid' and ('price' not in data or data['price'] <= 0): | |||
app/api/schema/tickets.py
Outdated
| def validate_price(self, data): | ||
| if data['type'] == 'paid' and ('price' not in data or data['price'] <= 0): | ||
| raise UnprocessableEntity({'pointer': 'data/attributes/price'}, | ||
| "paid ticket price should be valid") |
There was a problem hiding this comment.
Suggested change
| "paid ticket price should be valid") | |
| "paid ticket price should be greater than 0") |
iamareebjamal
approved these changes
Nov 18, 2019
|
Thanks, I made it..! |
codedsun
added a commit
to codedsun/open-event-server
that referenced
this pull request
Dec 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6597
Short description of what this resolves:
Handles when price for paid ticket is null or not an instance of float value
Changes proposed in this pull request:
Checklist
developmentbranch.