fix: Removing is_ticketing_enabled from event models #6634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #6634 +/- ##
===============================================
- Coverage 65.34% 65.34% -0.01%
===============================================
Files 298 298
Lines 15242 15239 -3
===============================================
- Hits 9960 9958 -2
+ Misses 5282 5281 -1
Continue to review full report at Codecov.
|
|
Don't drop the column please, just remove the field from schema and logic for it |
houndci-bot
reviewed
Nov 29, 2019
|
@iamareebjamal Please have a look |
|
Fix dredd tests |
|
@iamareebjamal Why the |
|
Because modules are not added in the hooks |
mrsaicharan1
suggested changes
Nov 29, 2019
| elif data.get('is_ticketing_enabled', True) and not modules.ticket_include: | ||
| raise ForbiddenException({'source': '/data/attributes/is-ticketing-enabled'}, | ||
| elif not modules.ticket_include: | ||
| raise ForbiddenException({'source': ''}, | ||
| "Ticketing is not enabled in the system") |
There was a problem hiding this comment.
"This event doesn't have any tickets"
|
Ticketing is not enables. Its corret error message
…On Fri, 29 Nov, 2019, 22:29 Saicharan Reddy, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Is the PR really doing what it's supposed to do?
------------------------------
In app/api/events.py
<#6634 (comment)>
:
> @@ -56,8 +56,8 @@ def validate_event(user, modules, data):
if not user.can_create_event():
raise ForbiddenException({'source': ''},
"Please verify your Email")
- elif data.get('is_ticketing_enabled', True) and not modules.ticket_include:
- raise ForbiddenException({'source': '/data/attributes/is-ticketing-enabled'},
+ elif not modules.ticket_include:
+ raise ForbiddenException({'source': ''},
"Ticketing is not enabled in the system")
"This event doesn't have any tickets"
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#6634?email_source=notifications&email_token=AKQMTLXIGRSOC7CK6EQAUR3QWFC7BA5CNFSM4JSZAFQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNOCSKI#pullrequestreview-324806953>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLXFZNP26SG42FSCYMDQWFC7BANCNFSM4JSZAFQQ>
.
|
|
Okay. |
|
@iamareebjamal Please review and merge |
iamareebjamal
approved these changes
Nov 29, 2019
iamareebjamal
changed the title
codedsun
pushed a commit
to codedsun/open-event-server
that referenced
this pull request
Dec 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers fossasia/open-event-frontend#3664