Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ticket end-date can be only within event end-date #6647

Merged
merged 5 commits into from Dec 24, 2019

Conversation

codedsun
Copy link
Contributor

@codedsun codedsun commented Dec 8, 2019

Fixes #6646

Short description of what this resolves:

fix: ticket end-date can be within event end-date

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@codecov
Copy link

codecov bot commented Dec 8, 2019

Codecov Report

Merging #6647 into development will decrease coverage by 0.12%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6647      +/-   ##
===============================================
- Coverage        65.44%   65.32%   -0.13%     
===============================================
  Files              300      298       -2     
  Lines            15299    15246      -53     
===============================================
- Hits             10012     9959      -53     
  Misses            5287     5287
Impacted Files Coverage Δ
app/api/tickets.py 47.16% <0%> (-1.38%) ⬇️
app/api/helpers/scheduled_jobs.py 24.39% <0%> (-4.08%) ⬇️
app/models/ticket_holder.py 78.46% <0%> (-0.65%) ⬇️
app/models/event.py 78.57% <0%> (-0.36%) ⬇️
app/__init__.py 88% <0%> (-0.24%) ⬇️
...all/integration/api/helpers/test_scheduled_jobs.py 100% <0%> (ø) ⬆️
app/factories/attendee.py 100% <0%> (ø) ⬆️
app/api/schema/__init__.py
app/extensions/shell.py
app/api/auth.py 24.15% <0%> (+0.32%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 692f7f9...fb3cf27. Read the comment docs.

@codedsun
Copy link
Contributor Author

codedsun commented Dec 8, 2019

@prateekj117 @iamareebjamal Review this. Thanks

@codedsun codedsun changed the title fix: ticket end-date can be within event end-date fix: ticket end-date can be only within event end-date Dec 8, 2019
@iamareebjamal iamareebjamal merged commit d19294b into fossasia:development Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tickets can be created with end date greater than event end date
3 participants