Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add created_at, modified_at in ticket_holder #6660

Merged
merged 1 commit into from Dec 13, 2019

Conversation

codedsun
Copy link
Contributor

Fixes #6655

Short description of what this resolves:

added created_at, modified_at in ticket_holder

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the feature label Dec 13, 2019
@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #6660 into development will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6660      +/-   ##
===============================================
- Coverage        65.33%   65.33%   -0.01%     
===============================================
  Files              298      298              
  Lines            15242    15244       +2     
===============================================
+ Hits              9959     9960       +1     
- Misses            5283     5284       +1
Impacted Files Coverage Δ
app/models/ticket_holder.py 79.1% <100%> (+0.64%) ⬆️
app/models/event.py 78.57% <0%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a2375a...8d91027. Read the comment docs.

@codedsun
Copy link
Contributor Author

@iamareebjamal Sir, please check. Thankyou!

@iamareebjamal
Copy link
Member

Verified that it is working correctly?

@codedsun
Copy link
Contributor Author

@iamareebjamal yes, i did

@iamareebjamal iamareebjamal changed the title feat: added created_at, modified_at in ticket_holder feat: add created_at, modified_at in ticket_holder Dec 13, 2019
@iamareebjamal
Copy link
Member

So, modified_at changes everytime I send a patch request?

@codedsun
Copy link
Contributor Author

codedsun commented Dec 13, 2019

@iamareebjamal Yes, I checkedin and checked out from frontend.

First column created_at, other verified_at

image

@iamareebjamal iamareebjamal merged commit 5a4ef10 into fossasia:development Dec 13, 2019
@codedsun
Copy link
Contributor Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add created_at, modified_at in ticket holders
2 participants