Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Added error handler for status 429 #6678
fix: Added error handler for status 429 #6678
Changes from 1 commit
7e824fe
dfcad5b
f6bd4b1
f5c7235
a00d19c
b6f948b
d104ea2
09614e9
2305a56
849040a
5c65efc
9937e99
73b2b98
d71b9c5
f21a822
569a696
9063705
9ef2e0d
cf80899
d0419ef
0c65e38
4ca8411
3403d03
a6b749d
1584492
ffd433d
9fb7911
2a1ec01
9c60849
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed. Try to understand the issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this? Keep it consistent with other handlers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please tell me where other error handlers are implemented @kushthedude? Because I first tried to find how other handlers were registered but was not able to find them. Also, issue #6665 says to register custom error handlers that means previously no custom error handlers are registered. Please guide me further if I am going wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are present in
__init__.py
of appAnd you can't just raise in an error handler itself. The raise is caught in error handler so that proper response can be returned from there. The app will crash if you raise in the error handler itself which has caught the error, hence no point of catching at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok @iamareebjamal. Working on it. Thanks for reviewing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove it