Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: remove events-orga endpoint #6714

Merged
merged 1 commit into from Jan 3, 2020

Conversation

codedsun
Copy link
Contributor

@codedsun codedsun commented Jan 2, 2020

Fixes #6710

Short description of what this resolves:

ref: remove events-orga endpoint

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@codedsun
Copy link
Contributor Author

codedsun commented Jan 2, 2020

@iamareebjamal As the issue states -

Create proper sales stats API if needed

The frontend is working fine after removing this afaik, what else needs to be tested here?

@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #6714 into development will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6714      +/-   ##
===============================================
- Coverage         65.6%   65.56%   -0.05%     
===============================================
  Files              303      300       -3     
  Lines            15353    15268      -85     
===============================================
- Hits             10073    10011      -62     
+ Misses            5280     5257      -23
Impacted Files Coverage Δ
app/api/schema/events.py 91.33% <ø> (-0.07%) ⬇️
app/api/routes.py 100% <ø> (ø) ⬆️
app/models/event.py 78.7% <ø> (-0.23%) ⬇️
app/models/event_orga.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f017de...221877a. Read the comment docs.

@iamareebjamal
Copy link
Member

A migration should be created to remove the table from DB

@codedsun
Copy link
Contributor Author

codedsun commented Jan 3, 2020

@iamareebjamal - Done check

@iamareebjamal iamareebjamal merged commit e315e36 into fossasia:development Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove event-orga endpoint
2 participants