fix: making the created_at dynamic for each order

[kushthedude]

Fixes #6703

[iamareebjamal]

That's not gonna work. created_at=None in constructor and in body.

if created_at is None:
    created_at = now()

[codecov]

Codecov Report

Merging #6721 into development will increase coverage by <.01%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           development    #6721      +/-   ##
===============================================
+ Coverage        65.61%   65.61%   +<.01%     
===============================================
  Files              300      300              
  Lines            15255    15257       +2     
===============================================
+ Hits             10009    10011       +2     
  Misses            5246     5246

Impacted Files	Coverage Δ
app/models/order.py	90.19% <100%> (+0.19%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2a4c8f...4c8355e. Read the comment docs.

[codedsun]

What's the difference b/w previous and this? @kushthedude
You are still doing the same thing.

[codedsun]

@iamareebjamal -

What's the difference in initializing in the constructor and now?
and what's the use of this?
if created_at is None: bcoz in the constructor we specified created_at = None. This condition is always true.

[iamareebjamal]

Not when created_at is passed in the constructor

[kushthedude]

When passed in constructor, every order is assigned the same createdAt status which onces expire was resulting into expiry of every order.

…

On Sat, 4 Jan, 2020, 19:15 Areeb Jamal, ***@***.***> wrote: Not when created_at is passed in the constructor — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6721?email_source=notifications&email_token=AKQMTLV7KY5RBEDIAYQLXGDQ4CHIPA5CNFSM4KCVWBB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEICYINA#issuecomment-570786868>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKQMTLXWNBGMBIL4FIAT5ADQ4CHIPANCNFSM4KCVWBBQ> .