fix: filtered deleted entities from user favourite events #6764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #6764 +/- ##
==============================================
- Coverage 65.4% 65.4% -0.01%
==============================================
Files 302 302
Lines 15364 15366 +2
==============================================
+ Hits 10049 10050 +1
- Misses 5315 5316 +1
Continue to review full report at Codecov.
|
codedsun
changed the title
codedsun
force-pushed
the
rating-event
branch
from
d702f9f
to
9c5a576
Compare
|
@iamareebjamal - REVIEW! |
app/api/user_favourite_events.py
Outdated
| user=current_user, event_id=view_kwargs['id']).first() | ||
| user_favourite_event = UserFavouriteEvent.query.filter_by(deleted_at=None, | ||
| user=current_user, | ||
| event_id=view_kwargs['id']).first() |
codedsun
force-pushed
the
rating-event
branch
from
9c5a576
to
25d4ad0
Compare
|
@iamareebjamal - Done |
iamareebjamal
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6762
Short description of what this resolves:
fix: filtered deleted events from user favourite events
Checklist
developmentbranch.