Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add check if donation ticket has payment method enabled #6789

Merged
merged 1 commit into from Jan 26, 2020
Merged

fix: add check if donation ticket has payment method enabled #6789

merged 1 commit into from Jan 26, 2020

Conversation

snitin315
Copy link
Member

Fixes #6788

Short description of what this resolves:

Server will throw an error Donation ticket must have a payment method as it throws in case of Paid Tickets

@auto-label auto-label bot added the fix label Jan 26, 2020
houndci-bot
houndci-bot reviewed Jan 26, 2020
View reviewed changes
app/api/tickets.py Outdated Show resolved Hide resolved
app/api/tickets.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 26, 2020 •
edited

Codecov Report

Merging #6789 into development will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6789   +/-   ##
============================================
  Coverage        65.28%   65.28%           
============================================
  Files              302      302           
  Lines            15277    15277           
============================================
  Hits              9974     9974           
  Misses            5303     5303
Impacted Files Coverage Δ
app/api/tickets.py 46.66% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1559c4c...5cca5be. Read the comment docs.

@snitin315 snitin315 force-pushed the donation-ticket branch 2 times, most recently from ca151d7 to b4efb5f Compare January 26, 2020 11:02
houndci-bot
houndci-bot reviewed Jan 26, 2020
View reviewed changes
app/api/tickets.py Outdated Show resolved Hide resolved
@iamareebjamal
Copy link
Member

Please run this and recommit:

pip install -r requirements/dev.txt
pre-commit install
black .

kushthedude
kushthedude reviewed Jan 26, 2020
View reviewed changes
app/api/tickets.py Outdated Show resolved Hide resolved
@snitin315 snitin315 force-pushed the donation-ticket branch 2 times, most recently from 9060006 to bd4e62d Compare January 26, 2020 12:35
kushthedude
kushthedude previously approved these changes Jan 26, 2020
View reviewed changes
iamareebjamal
iamareebjamal requested changes Jan 26, 2020
View reviewed changes
app/api/tickets.py Outdated Show resolved Hide resolved
@iamareebjamal iamareebjamal changed the title fix: payment method must be enabled for donation ticket fix: add check if donation ticket has payment method enabled Jan 26, 2020
@iamareebjamal iamareebjamal merged commit ac1ae07 into fossasia:development Jan 26, 2020
@snitin315 snitin315 deleted the donation-ticket branch February 5, 2020 14:37
@kushthedude kushthedude mentioned this pull request Feb 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@iamareebjamal iamareebjamal iamareebjamal approved these changes

@codedsun codedsun codedsun approved these changes

@kushthedude kushthedude kushthedude left review comments

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

user is able to save event without selecting payment method for donation ticket.
5 participants
@snitin315 @iamareebjamal @houndci-bot @codedsun @kushthedude