Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge local and global installation steps #7174

Conversation

Ranjit1312
Copy link
Contributor

Fixes #7160

Short description of what this resolves:

Merge local and global installation steps in basic.md.

Changes proposed in this pull request:

  • Removed local.md
  • Updated Readme.md

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Open a terminal and enter the following commands to setup a virtual environment

```sh
sudo apt-get install python3.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step is repeated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #7174 (a86db70) into development (b2f7a5d) will increase coverage by 0.51%.
The diff coverage is n/a.

❗ Current head a86db70 differs from pull request most recent head 090ceae. Consider uploading reports for the commit 090ceae to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7174      +/-   ##
===============================================
+ Coverage        66.03%   66.55%   +0.51%     
===============================================
  Files              305      303       -2     
  Lines            15691    15499     -192     
===============================================
- Hits             10362    10315      -47     
+ Misses            5329     5184     -145     
Impacted Files Coverage Δ
app/api/admin_sales/events.py 75.51% <0.00%> (-12.59%) ⬇️
app/api/schema/sessions.py 94.00% <0.00%> (-0.24%) ⬇️
app/models/session.py 92.78% <0.00%> (-0.08%) ⬇️
app/api/schema/events.py 98.63% <0.00%> (-0.01%) ⬇️
app/api/users.py 28.14% <0.00%> (ø)
app/models/custom_form.py 98.18% <0.00%> (ø)
app/api/helpers/system_mails.py 100.00% <0.00%> (ø)
session_slides_type_to_json.py
app/api/helpers/group_user_role.py
app/api/helpers/mail.py 33.17% <0.00%> (+0.31%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f7a5d...090ceae. Read the comment docs.

@Ranjit1312
Copy link
Contributor Author

@iamareebjamal
I have made requested changes please review.

@hongquan
Copy link
Member

hongquan commented Jun 3, 2021

@Ranjit1312 Please resolve conflict.

@maze-runnar maze-runnar merged commit 844314c into fossasia:development Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge local installation steps and generic installation steps
4 participants