Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation for donation ticket price #8219

Merged
merged 5 commits into from Sep 30, 2021
Merged

fix: validation for donation ticket price #8219

merged 5 commits into from Sep 30, 2021

Conversation

maze-runnar
Copy link
Contributor

Fixes fossasia/open-event-frontend#7816

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the fix label Sep 20, 2021
mariobehling
mariobehling previously approved these changes Sep 20, 2021
@mariobehling
Copy link
Member

Please fix Circle-CI tests before merging. Thanks

@maze-runnar
Copy link
Contributor Author

Please fix Circle-CI tests before merging. Thanks

yes, fixing tests.

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #8219 (e0c82cf) into development (45f6f9e) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #8219      +/-   ##
===============================================
- Coverage        65.74%   65.73%   -0.01%     
===============================================
  Files              305      305              
  Lines            15810    15813       +3     
===============================================
+ Hits             10394    10395       +1     
- Misses            5416     5418       +2     
Impacted Files Coverage Δ
app/api/custom/orders.py 67.00% <33.33%> (-1.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45f6f9e...e0c82cf. Read the comment docs.

@mariobehling mariobehling merged commit 8768818 into fossasia:development Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Box to enter amount for donation registration missing
3 participants