Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticket directs to ticket page #2102

Merged
merged 3 commits into from
Sep 28, 2018
Merged

ticket directs to ticket page #2102

merged 3 commits into from
Sep 28, 2018

Conversation

Ananthavijay
Copy link
Contributor

@Ananthavijay Ananthavijay commented Sep 16, 2018

Checklist

Short description of what this resolves:

Changes proposed in this pull request:

  • ticket directs to ticket page instead of top button

Fixes #2094

Copy link
Member

@starkblaze01 starkblaze01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ananthavijay
Copy link
Contributor Author

@mariobehling pls review and merge

Copy link
Member

@agbilotia1998 agbilotia1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct way of doing this, check out the tickets button in event.hbs, the redirect URL should be the same as that.

@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #2102 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #2102   +/-   ##
============================================
  Coverage        76.81%   76.81%           
============================================
  Files                8        8           
  Lines             1919     1919           
  Branches           358      358           
============================================
  Hits              1474     1474           
  Misses             445      445

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b69b36...7731e80. Read the comment docs.

@Ananthavijay
Copy link
Contributor Author

@agbilotia1998 now?

Copy link
Member

@agbilotia1998 agbilotia1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@agbilotia1998 agbilotia1998 merged commit c31ad5b into fossasia:development Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ticket link on footer should direct to Ticket Page instead of top button
3 participants