Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Simplifies the form, set the default api to v2, pre-selected the desired options, text fixes #2349

Merged
merged 2 commits into from Oct 13, 2020

Conversation

rishi-raj-jain
Copy link
Contributor

@rishi-raj-jain rishi-raj-jain commented Sep 29, 2020

Checklist

[Performed as a part of Codeheat]

Short description of what this resolves:

This commit resolves the desired changes in issue #2335. Change of spellings & font-weight(bold), Pre-selecting Expandable & Open Street Map and getting rid of the "Choose your API version" by setting it to the default v2 as desired.

Though I was not able to deploy the app because to deploy it to either heroku/any other service, either they are paid or need a credit card(for heroku redis) and I don't have that..

Here's the link to the updated app's recording (as suggested): https://open-event-wsgen-2335.vercel.app/248182f3-1663-4b29-b161-e4612701e35d.webm

[One of the solutions to view the code working can be that you can give me a slot in which you'll be reviewing the commit and then I'll be more than happy to attach a link to ngrok so that the commit be tested. Please guide in case any other way out is possible.]

Changes proposed in this pull request:

  • Change postion: relative to position: relative,
  • Got rid of underscores and bold to unbold,
  • Removed the "Choose your API version" and set it default to data.apiVersion= 'api_v2'; in the script,
  • As now auto-select to api endpoint has been done, the field to the link of it is also set enabled by default, hence the generate webapp button also. (By script's initialState)

Fixes #2335

@rishi-raj-jain rishi-raj-jain changed the title Simplifies the form, set the default api to v2, pre-selected the desired options, test fixes Simplifies the form, set the default api to v2, pre-selected the desired options, text fixes Sep 29, 2020
Copy link
Member

@Raunaksingh100 Raunaksingh100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz fixed your travis Cl failed .........

@rishi-raj-jain
Copy link
Contributor Author

@Raunaksingh100 The travis CI is failing because of Selenium Timeout and not of any other errors.

@iamareebjamal iamareebjamal changed the title Simplifies the form, set the default api to v2, pre-selected the desired options, text fixes fix: Simplifies the form, set the default api to v2, pre-selected the desired options, text fixes Oct 13, 2020
@auto-label auto-label bot added the fix label Oct 13, 2020
@iamareebjamal
Copy link
Member

Great job! Thank you

@iamareebjamal iamareebjamal merged commit f622c88 into fossasia:development Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify Form: Take out API version, pre-select options, fix spelling
3 participants